fix: replace node buffers with uint8arrays #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All uses of node Buffers have been replaced with Uint8Arrays BREAKING CHANGES: - The `.data` and `.seq` properties of messages used to be node Buffers, now they are Uint8Arrays - All deps of this module now use Uint8Arrays instead of Buffers
64 tasks
Codecov Report
@@ Coverage Diff @@
## master #118 +/- ##
=======================================
Coverage 80.00% 80.00%
=======================================
Files 1 1
Lines 10 10
=======================================
Hits 8 8
Misses 2 2 Continue to review full report at Codecov.
|
vasco-santos
approved these changes
Aug 11, 2020
Collaborator
vasco-santos
left a comment
vasco-santos
left a comment
There was a problem hiding this comment.
LGTM!
@wemeetagain this will need to be rebased for gossipsub1.1. I
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All uses of node Buffers have been replaced with Uint8Arrays
Depends on:
BREAKING CHANGES:
.dataand.seqproperties of messages used to be node Buffers, now they are Uint8Arrays