dot/rpc: Implement RPC author_insertKey#765
Merged
edwardmack merged 8 commits intodevelopmentfrom Apr 10, 2020
Merged
Conversation
Contributor
|
@edwardmack I think just putting them into the keystore as you're doing right now is okay, and yeah they should be sr25519 keys. in the future we should probably have separate keystores for babe, grandpa, etc. let's make an issue for that |
noot
reviewed
Apr 10, 2020
| } | ||
|
|
||
| // newTestService creates a new test core service | ||
| func newTestService(t *testing.T, cfg *core.Config) *core.Service { |
Contributor
There was a problem hiding this comment.
maybe we could move this to dot/core/test_helpers.go and export it? just so we don't need to duplicate code
ryanchristo
approved these changes
Apr 10, 2020
Contributor
ryanchristo
left a comment
ryanchristo
left a comment
There was a problem hiding this comment.
This looks good to me. Nice work!
ryanchristo
pushed a commit
that referenced
this pull request
Jun 24, 2020
* add InsertKey interface * implement author_insertKey * lint issues * added tests for author_insertKey * remove unnecessary logging * fix imports merge conflict * move newTestSerice to test_helper.go and make public
This was referenced Oct 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces implementation of RPC call author_insertKey, which inserts the given key into the core keystore. Defined in https://github.com/w3f/PSPs/blob/psp-rpc-api/psp-002.md#author_insertKey
Changes
Tests:
AND
Issues: