dot/rpc; implement RPC chain_getBlockHash#752
Merged
edwardmack merged 5 commits intodevelopmentfrom Apr 7, 2020
Merged
Conversation
noot
reviewed
Apr 7, 2020
| return stateSrvc | ||
| } | ||
|
|
||
| func loadTestBlocks(gh common.Hash, bs *state.BlockState) error { |
Contributor
There was a problem hiding this comment.
there's another test function in state called addBlocksToState where you can specify the depth (the branching part of that function probably isn't too relevant here) that might be useful in the future for adding more than 2 blocks
Contributor
Author
There was a problem hiding this comment.
excellent, I thought there may be something, but I didn't look deeply enough. Will come in handy.
ryanchristo
approved these changes
Apr 7, 2020
Contributor
ryanchristo
left a comment
ryanchristo
left a comment
There was a problem hiding this comment.
Nice work! Looks good to me.
| Number: big.NewInt(0), | ||
| StateRoot: "0x03170a2e7597b7b7e3d84c05391d139a62b157e78786d8c082f29dcf4c111314", | ||
| ExtrinsicsRoot: "0x03170a2e7597b7b7e3d84c05391d139a62b157e78786d8c082f29dcf4c111314", | ||
| ParentHash: "0xdbfdd87392d9ee52f499610582737daceecf83dc3ad7946fcadeb01c86e1ef75", |
Contributor
There was a problem hiding this comment.
maybe just a comment to explain where this and the other test hashes are coming from?
ryanchristo
pushed a commit
that referenced
this pull request
Jun 24, 2020
* implement chain_getBlockHash * added tests for chain_getBlockHash * lint cleanup * cleanup comments
This was referenced Oct 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Tests:
Issues: