Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dot/parachain/backing): rename GetBackedCandidatesMessage to GetBackableCandidatesMessage #4063

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

axaysagathiya
Copy link
Contributor

@axaysagathiya axaysagathiya commented Jun 25, 2024

Changes

  • rename struct from GetBackedCandidatesMessage to GetBackableCandidatesMessage.
  • rename function from handleGetBackedCandidatesMessage to handleGetBackableCandidatesMessage.

Tests

go test -tags integration github.com/ChainSafe/gossamer

Issues

closes #4062

Other information

As GetBackedCandidatesMessage returns a list of backable candidates, I've renamed it to GetBackableCandidatesMessage.

Backable Candidate: If a candidate receives enough supporting Statements from the Parachain Validators currently assigned, that candidate is considered backable.

  • Legacy backing: we need 2(pre-defined) supporting votes to consider the candidate a backable.
  • Async backing: Call the runtime method to get the minimum number of backing votes required.

Backed Candidate: A Backable Candidate noted in a relay-chain block

Copy link
Contributor

@kishansagathiya kishansagathiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@axaysagathiya axaysagathiya merged commit 62fe5fb into feat/parachain Jun 27, 2024
22 checks passed
@axaysagathiya axaysagathiya deleted the rename-getBacked-to-getBackable branch June 27, 2024 09:49
kishansagathiya pushed a commit that referenced this pull request Jul 15, 2024
kishansagathiya pushed a commit that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants