-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dot/parachain/backing): implement a func to get attested candidate from statement table #3939
Merged
axaysagathiya
merged 11 commits into
feat/parachain
from
axay/feat/backing/statement-table/attested-candidate
May 22, 2024
Merged
feat(dot/parachain/backing): implement a func to get attested candidate from statement table #3939
axaysagathiya
merged 11 commits into
feat/parachain
from
axay/feat/backing/statement-table/attested-candidate
May 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axaysagathiya
requested review from
edwardmack,
timwu20,
EclesioMeloJunior,
jimjbrettj,
kishansagathiya and
dimartiro
as code owners
May 10, 2024 09:28
timwu20
reviewed
May 11, 2024
edwardmack
approved these changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work.
…f github.com:ChainSafe/gossamer into axay/feat/backing/statement-table/attested-candidate
timwu20
reviewed
May 22, 2024
timwu20
approved these changes
May 22, 2024
…attested-candidate
axaysagathiya
deleted the
axay/feat/backing/statement-table/attested-candidate
branch
May 22, 2024 17:59
timwu20
pushed a commit
that referenced
this pull request
Jun 17, 2024
…te from statement table (#3939) This PR implements a method for getting an attested candidate from the statement table for the candidate hash. - Added extra argument to interface method to get an attested candidate - Implemented the same method of an interface - There is no need for scale encoding/decoding to attestedCandidate, so I removed scale tags from the same struct. - wrote unit tests for the same
timwu20
pushed a commit
that referenced
this pull request
Jun 17, 2024
…te from statement table (#3939) This PR implements a method for getting an attested candidate from the statement table for the candidate hash. - Added extra argument to interface method to get an attested candidate - Implemented the same method of an interface - There is no need for scale encoding/decoding to attestedCandidate, so I removed scale tags from the same struct. - wrote unit tests for the same
timwu20
pushed a commit
that referenced
this pull request
Jun 20, 2024
…te from statement table (#3939) This PR implements a method for getting an attested candidate from the statement table for the candidate hash. - Added extra argument to interface method to get an attested candidate - Implemented the same method of an interface - There is no need for scale encoding/decoding to attestedCandidate, so I removed scale tags from the same struct. - wrote unit tests for the same
kishansagathiya
pushed a commit
that referenced
this pull request
Jul 15, 2024
…te from statement table (#3939) This PR implements a method for getting an attested candidate from the statement table for the candidate hash. - Added extra argument to interface method to get an attested candidate - Implemented the same method of an interface - There is no need for scale encoding/decoding to attestedCandidate, so I removed scale tags from the same struct. - wrote unit tests for the same
kishansagathiya
pushed a commit
that referenced
this pull request
Jul 15, 2024
…te from statement table (#3939) This PR implements a method for getting an attested candidate from the statement table for the candidate hash. - Added extra argument to interface method to get an attested candidate - Implemented the same method of an interface - There is no need for scale encoding/decoding to attestedCandidate, so I removed scale tags from the same struct. - wrote unit tests for the same
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a method for getting an attested candidate from the statement table for the candidate hash.
Changes
Rust implementation: https://github.com/paritytech/polkadot-sdk/blob/7ca0d65f19497ac1c3c7ad6315f1a0acb2ca32f8/polkadot/statement-table/src/generic.rs#L318-L334
Issues
#3471
Primary Reviewer
@kishansagathiya @edwardmack