-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/parachain: network bridge skeleton #3885
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kishansagathiya
requested review from
edwardmack,
timwu20,
EclesioMeloJunior,
jimjbrettj,
dimartiro and
axaysagathiya
as code owners
April 12, 2024 12:33
kishansagathiya
changed the title
Network bridge skeleton
feat/parachain: network bridge skeleton
Apr 12, 2024
axaysagathiya
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix lint, add //nolint
edwardmack
approved these changes
Apr 15, 2024
This was referenced Apr 16, 2024
edwardmack
pushed a commit
that referenced
this pull request
Apr 16, 2024
timwu20
pushed a commit
that referenced
this pull request
Jun 17, 2024
timwu20
pushed a commit
that referenced
this pull request
Jun 17, 2024
timwu20
pushed a commit
that referenced
this pull request
Jun 20, 2024
kishansagathiya
added a commit
that referenced
this pull request
Jul 15, 2024
kishansagathiya
added a commit
that referenced
this pull request
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This commit introduces network bridge skeleton for receiving side subsystem and sending side subsystem of network bridge
Tests
go test -tags integration github.com/ChainSafe/gossamer
Issues
Fixes #3860 and #3858
Primary Reviewer
@axaysagathiya @edwardmack