Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lib/erasure): Move test assertion to non-error condition #3371

Merged
merged 1 commit into from
Jul 7, 2023
Merged

fix(lib/erasure): Move test assertion to non-error condition #3371

merged 1 commit into from
Jul 7, 2023

Conversation

edwardmack
Copy link
Member

Changes

  • Moved assertion that confirms expected chunks to only check when no error is expected since the expected chunks or not consistent when there is an error.
  • added t.Parallel to tests

Tests

go test github.com/ChainSafe/gossamer/lib/erasure-coding -v

Issues

Primary Reviewer

@kanishkatn

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #3371 (2b2e9fd) into feat/parachain (d1037b4) will increase coverage by 0.24%.
The diff coverage is n/a.

Additional details and impacted files 
@@                Coverage Diff                 @@
##           feat/parachain    #3371      +/-   ##
==================================================
+ Coverage           51.43%   51.68%   +0.24%     
==================================================
  Files                 235      234       -1     
  Lines               28706    28595     -111     
==================================================
+ Hits                14765    14778      +13     
+ Misses              12505    12393     -112     
+ Partials             1436     1424      -12

@kanishkatn kanishkatn merged commit fee212d into feat/parachain Jul 7, 2023
@kanishkatn kanishkatn deleted the ed/erasure_coding_test_update branch July 7, 2023 04:19
kishansagathiya pushed a commit that referenced this pull request Jul 12, 2023
@edwardmack @kishansagathiya
fix(lib/erasure): Move test assertion to non-error condition (#3371)
1ddf3be
kishansagathiya pushed a commit that referenced this pull request Jul 12, 2023
@edwardmack @kishansagathiya
fix(lib/erasure): Move test assertion to non-error condition (#3371)
b97656e
kishansagathiya pushed a commit that referenced this pull request Jul 14, 2023
@edwardmack @kishansagathiya
fix(lib/erasure): Move test assertion to non-error condition (#3371)
a25cadc
kishansagathiya pushed a commit that referenced this pull request Jul 27, 2023
@edwardmack @kishansagathiya
fix(lib/erasure): Move test assertion to non-error condition (#3371)
838ae5f
kishansagathiya pushed a commit that referenced this pull request Aug 4, 2023
@edwardmack @kishansagathiya
fix(lib/erasure): Move test assertion to non-error condition (#3371)
85a7499
kishansagathiya pushed a commit that referenced this pull request Aug 22, 2023
@edwardmack @kishansagathiya
fix(lib/erasure): Move test assertion to non-error condition (#3371)
d5fbae6
kishansagathiya pushed a commit that referenced this pull request Aug 22, 2023
@edwardmack @kishansagathiya
fix(lib/erasure): Move test assertion to non-error condition (#3371)
1289425
edwardmack added a commit that referenced this pull request Aug 30, 2023
@edwardmack
fix(lib/erasure): Move test assertion to non-error condition (#3371)
c44c5ca
edwardmack added a commit that referenced this pull request Aug 31, 2023
@edwardmack
fix(lib/erasure): Move test assertion to non-error condition (#3371)
959dda2
kishansagathiya pushed a commit that referenced this pull request Sep 14, 2023
@edwardmack @kishansagathiya
fix(lib/erasure): Move test assertion to non-error condition (#3371)
b8ddd99
kishansagathiya pushed a commit that referenced this pull request Jan 23, 2024
@edwardmack @kishansagathiya
fix(lib/erasure): Move test assertion to non-error condition (#3371)
bed63fa
kishansagathiya pushed a commit that referenced this pull request Jan 24, 2024
@edwardmack @kishansagathiya
fix(lib/erasure): Move test assertion to non-error condition (#3371)
dec23c9
timwu20 pushed a commit that referenced this pull request Jun 13, 2024
@edwardmack @timwu20
fix(lib/erasure): Move test assertion to non-error condition (#3371)
06b7056
timwu20 pushed a commit that referenced this pull request Jun 17, 2024
@edwardmack @timwu20
fix(lib/erasure): Move test assertion to non-error condition (#3371)
ba9f1c3
timwu20 pushed a commit that referenced this pull request Jun 20, 2024
@edwardmack @timwu20
fix(lib/erasure): Move test assertion to non-error condition (#3371)
0dd78d4
kishansagathiya pushed a commit that referenced this pull request Jul 15, 2024
@edwardmack @kishansagathiya
fix(lib/erasure): Move test assertion to non-error condition (#3371)
1e51ff3
kishansagathiya pushed a commit that referenced this pull request Jul 15, 2024
@edwardmack @kishansagathiya
fix(lib/erasure): Move test assertion to non-error condition (#3371)
c12ba96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimartiro dimartiro dimartiro approved these changes

@kanishkatn kanishkatn kanishkatn approved these changes

@EclesioMeloJunior EclesioMeloJunior EclesioMeloJunior approved these changes

@jimjbrettj jimjbrettj jimjbrettj approved these changes

@timwu20 timwu20 Awaiting requested review from timwu20 timwu20 is a code owner

@kishansagathiya kishansagathiya Awaiting requested review from kishansagathiya kishansagathiya is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@edwardmack @dimartiro @kanishkatn @EclesioMeloJunior @jimjbrettj