Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(parachain): Add StatementDistributionMessage varingDataType #3316

Merged
merged 19 commits into from
Jun 20, 2023
Merged

feat(parachain): Add StatementDistributionMessage varingDataType #3316

merged 19 commits into from
Jun 20, 2023

Conversation

axaysagathiya
Copy link
Contributor

@axaysagathiya axaysagathiya commented Jun 13, 2023 •
edited
Loading

Changes

Tests

go test -tags integration github.com/ChainSafe/gossamer

Issues

Fixes #3289

Primary Reviewer

@timwu20

@axaysagathiya axaysagathiya marked this pull request as ready for review June 15, 2023 08:19
kishansagathiya
kishansagathiya reviewed Jun 16, 2023
View reviewed changes
Copy link
Contributor

@kishansagathiya kishansagathiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Great work.

Few suggestions to make this ready

  • Add comment to fix linting
  • Now that types PR got merged, see which structs can be reused.

parachain/statement_distribution_message.go Outdated Show resolved Hide resolved
parachain/statement_distribution_message.go Outdated Show resolved Hide resolved
kishansagathiya
kishansagathiya approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@kishansagathiya kishansagathiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

epic

kishansagathiya pushed a commit that referenced this pull request Jul 14, 2023
@axaysagathiya @kishansagathiya
feat(parachain): Add StatementDistributionMessage varingDataType (#3316)
56c37d2
@axaysagathiya axaysagathiya deleted the issue-3289 branch July 21, 2023 07:15
kishansagathiya pushed a commit that referenced this pull request Jul 27, 2023
@axaysagathiya @kishansagathiya
feat(parachain): Add StatementDistributionMessage varingDataType (#3316)
dcc31f1
edwardmack pushed a commit that referenced this pull request Jul 27, 2023
@axaysagathiya @edwardmack
feat(parachain): Add StatementDistributionMessage varingDataType (#3316)
62b871c
edwardmack pushed a commit that referenced this pull request Jul 27, 2023
@axaysagathiya @edwardmack
feat(parachain): Add StatementDistributionMessage varingDataType (#3316)
1119b7b
edwardmack pushed a commit that referenced this pull request Jul 27, 2023
@axaysagathiya @edwardmack
feat(parachain): Add StatementDistributionMessage varingDataType (#3316)
c172515
kishansagathiya pushed a commit that referenced this pull request Aug 4, 2023
@axaysagathiya @kishansagathiya
feat(parachain): Add StatementDistributionMessage varingDataType (#3316)
fcbd4e7
edwardmack pushed a commit that referenced this pull request Aug 16, 2023
@axaysagathiya @edwardmack
feat(parachain): Add StatementDistributionMessage varingDataType (#3316)
2db564d
kishansagathiya pushed a commit that referenced this pull request Aug 22, 2023
@axaysagathiya @kishansagathiya
feat(parachain): Add StatementDistributionMessage varingDataType (#3316)
3f67c50
kishansagathiya pushed a commit that referenced this pull request Aug 22, 2023
@axaysagathiya @kishansagathiya
feat(parachain): Add StatementDistributionMessage varingDataType (#3316)
42256b3
edwardmack pushed a commit that referenced this pull request Aug 30, 2023
@axaysagathiya @edwardmack
feat(parachain): Add StatementDistributionMessage varingDataType (#3316)
067ee13
edwardmack pushed a commit that referenced this pull request Aug 31, 2023
@axaysagathiya @edwardmack
feat(parachain): Add StatementDistributionMessage varingDataType (#3316)
8d66673
edwardmack added a commit that referenced this pull request Aug 31, 2023
@edwardmack
feat(parachain): Add StatementDistributionMessage varingDataType (#3316)
f0e650e
kishansagathiya pushed a commit that referenced this pull request Sep 14, 2023
@axaysagathiya @kishansagathiya
feat(parachain): Add StatementDistributionMessage varingDataType (#3316)
be2aaea
edwardmack pushed a commit that referenced this pull request Sep 18, 2023
@axaysagathiya @edwardmack
feat(parachain): Add StatementDistributionMessage varingDataType (#3316)
6b0b0cc
kishansagathiya pushed a commit that referenced this pull request Jan 23, 2024
@axaysagathiya @kishansagathiya
feat(parachain): Add StatementDistributionMessage varingDataType (#3316)
80c82cd
kishansagathiya pushed a commit that referenced this pull request Jan 24, 2024
@axaysagathiya @kishansagathiya
feat(parachain): Add StatementDistributionMessage varingDataType (#3316)
8f8dec2
edwardmack pushed a commit that referenced this pull request Jan 28, 2024
@axaysagathiya @edwardmack
feat(parachain): Add StatementDistributionMessage varingDataType (#3316)
0709412
edwardmack pushed a commit that referenced this pull request Mar 5, 2024
@axaysagathiya @edwardmack
feat(parachain): Add StatementDistributionMessage varingDataType (#3316)
90b880d
edwardmack pushed a commit that referenced this pull request Apr 2, 2024
@axaysagathiya @edwardmack
feat(parachain): Add StatementDistributionMessage varingDataType (#3316)
1848608
edwardmack pushed a commit that referenced this pull request Apr 12, 2024
@axaysagathiya @edwardmack
feat(parachain): Add StatementDistributionMessage varingDataType (#3316)
e6cba07
edwardmack pushed a commit that referenced this pull request Apr 24, 2024
@axaysagathiya @edwardmack
feat(parachain): Add StatementDistributionMessage varingDataType (#3316)
91cd8f1
edwardmack pushed a commit that referenced this pull request Apr 30, 2024
@axaysagathiya @edwardmack
feat(parachain): Add StatementDistributionMessage varingDataType (#3316)
58c709a
timwu20 pushed a commit that referenced this pull request Jun 13, 2024
@axaysagathiya @timwu20
feat(parachain): Add StatementDistributionMessage varingDataType (#3316)
1edd3ab
timwu20 pushed a commit that referenced this pull request Jun 17, 2024
@axaysagathiya @timwu20
feat(parachain): Add StatementDistributionMessage varingDataType (#3316)
79b0c99
timwu20 pushed a commit that referenced this pull request Jun 20, 2024
@axaysagathiya @timwu20
feat(parachain): Add StatementDistributionMessage varingDataType (#3316)
690037d
edwardmack pushed a commit that referenced this pull request Jun 26, 2024
@axaysagathiya @edwardmack
feat(parachain): Add StatementDistributionMessage varingDataType (#3316)
61c79e4
edwardmack pushed a commit that referenced this pull request Jul 12, 2024
@axaysagathiya @edwardmack
feat(parachain): Add StatementDistributionMessage varingDataType (#3316)
dd1ae6e
kishansagathiya pushed a commit that referenced this pull request Jul 15, 2024
@axaysagathiya @kishansagathiya
feat(parachain): Add StatementDistributionMessage varingDataType (#3316)
96307f8
kishansagathiya pushed a commit that referenced this pull request Jul 15, 2024
@axaysagathiya @kishansagathiya
feat(parachain): Add StatementDistributionMessage varingDataType (#3316)
35a3d3a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanishkatn kanishkatn kanishkatn approved these changes

@kishansagathiya kishansagathiya kishansagathiya approved these changes

@edwardmack edwardmack Awaiting requested review from edwardmack

@timwu20 timwu20 Awaiting requested review from timwu20 timwu20 is a code owner

@EclesioMeloJunior EclesioMeloJunior Awaiting requested review from EclesioMeloJunior EclesioMeloJunior is a code owner

@jimjbrettj jimjbrettj Awaiting requested review from jimjbrettj jimjbrettj is a code owner

@dimartiro dimartiro Awaiting requested review from dimartiro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@axaysagathiya @kanishkatn @kishansagathiya