chore(dot/rpc): NewStateRuntimeVersionResponse#2740
Merged
qdm12 merged 1 commit intodevelopmentfrom Aug 16, 2022
Merged
Conversation
qdm12
force-pushed
the
qdm12/runtime/version-structs-refactor
branch
from
b187971 to
ab9721f
Compare
qdm12
force-pushed
the
qdm12/dot/rpc/runtimeversion-constructor
branch
from
9606a29 to
f6872a7
Compare
qdm12
requested review from
EclesioMeloJunior,
edwardmack,
jimjbrettj,
kishansagathiya,
noot and
timwu20
as code owners
qdm12
force-pushed
the
qdm12/runtime/version-structs-refactor
branch
4 times, most recently
from
c4e418d to
a2b9f95
Compare
qdm12
force-pushed
the
qdm12/dot/rpc/runtimeversion-constructor
branch
from
f6872a7 to
a72684b
Compare
timwu20
approved these changes
Aug 11, 2022
qdm12
force-pushed
the
qdm12/runtime/version-structs-refactor
branch
from
b5dd0cd to
11e5200
Compare
qdm12
force-pushed
the
qdm12/dot/rpc/runtimeversion-constructor
branch
from
a72684b to
fcac1f3
Compare
qdm12
force-pushed
the
qdm12/runtime/version-structs-refactor
branch
from
11e5200 to
6486321
Compare
qdm12
force-pushed
the
qdm12/dot/rpc/runtimeversion-constructor
branch
from
fcac1f3 to
cb8bd82
Compare
qdm12
force-pushed
the
qdm12/runtime/version-structs-refactor
branch
from
6486321 to
3386e46
Compare
qdm12
force-pushed
the
qdm12/dot/rpc/runtimeversion-constructor
branch
from
cb8bd82 to
dbda743
Compare
Base automatically changed from
qdm12/runtime/version-structs-refactor
to
development
August 16, 2022 12:09
- Inline `modules.ConvertAPIs` in constructor - Replace conversions with new constructor - Update tests to have explicit expected API items
qdm12
force-pushed
the
qdm12/dot/rpc/runtimeversion-constructor
branch
from
dbda743 to
7cd481a
Compare
jimjbrettj
reviewed
Aug 16, 2022
jimjbrettj
approved these changes
Aug 16, 2022
Contributor
jimjbrettj
left a comment
jimjbrettj
left a comment
There was a problem hiding this comment.
Looks good, just one comment
|
🎉 This PR is included in version 0.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
NewStateRuntimeVersionResponsemodules.ConvertAPIscontent inNewStateRuntimeVersionResponseNewStateRuntimeVersionResponsemodules.ConvertAPIsTests
go test -tags integration github.com/ChainSafe/gossamerIssues
Created from a comment in #2673
Primary Reviewer
@timwu20