Skip to content

fix(lib/babe): check if authority index is in the authorities range #2601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EclesioMeloJunior merged 4 commits into from
Jun 21, 2022
Merged

fix(lib/babe): check if authority index is in the authorities range #2601

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9d20bae
fix: check for negative values
EclesioMeloJunior Jun 13, 2022
199efc8
Update lib/babe/verify.go
EclesioMeloJunior Jun 14, 2022
cee7244
Update verify.go
EclesioMeloJunior Jun 15, 2022
b9268b9
Update verify.go
EclesioMeloJunior Jun 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/babe/verify.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,7 @@ func (b *verifier) verifyPreRuntimeDigest(digest *types.PreRuntimeDigest) (scale
authIdx = d.AuthorityIndex
}

if len(b.authorities) <= int(authIdx) {
if int(authIdx) < 0 || int(authIdx) >= len(b.authorities) {
Comment thread
EclesioMeloJunior marked this conversation as resolved.
Outdated
logger.Tracef("verifyPreRuntimeDigest invalid auth index %d, we have %d auths",
authIdx, len(b.authorities))
return nil, ErrInvalidBlockProducerIndex
Expand Down