Skip to content

fix(cmd): avoid nil pointer dereference #2578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EclesioMeloJunior merged 4 commits into from
Jun 3, 2022
Merged

fix(cmd): avoid nil pointer dereference #2578

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f7cf8cc
fix: avoid nil pointer dereference
EclesioMeloJunior Jun 2, 2022
7d84c93
chore: ensure the `tomlConfigValue` is not nil in the caller layer
EclesioMeloJunior Jun 2, 2022
4126d02
chore: address comments
EclesioMeloJunior Jun 3, 2022
47150c4
chore: using the printf to print as string
EclesioMeloJunior Jun 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/gossamer/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,7 +528,7 @@ func setDotGlobalConfigName(ctx *cli.Context, tomlCfg *ctoml.Config, cfg *dot.Gl
}

// consider the name on config as a second priority
if tomlCfg.Global.Name != "" {
if tomlCfg != nil && tomlCfg.Global.Name != "" {
Comment thread
EclesioMeloJunior marked this conversation as resolved.
Outdated
cfg.Name = tomlCfg.Global.Name
return nil
}
Expand Down
4 changes: 2 additions & 2 deletions cmd/gossamer/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,9 @@ var (
Description: "The build-spec command outputs current genesis JSON data.\n" +
"\tUsage: gossamer build-spec\n" +
"\tTo generate raw genesis file from default: " +
"gossamer build-spec --raw > genesis.json" +
"gossamer build-spec --raw --output genesis.json" +
"\tTo generate raw genesis file from specific genesis file: " +
"gossamer build-spec --raw --genesis genesis-spec.json > genesis.json",
"gossamer build-spec --raw --genesis genesis-spec.json --output genesis.json",
}

// importRuntime generates a genesis file given a .wasm runtime binary.
Expand Down