chore(internal/trie/node): remove all mutexes#2301
Merged
qdm12 merged 1 commit intodevelopmentfrom Feb 23, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## development #2301 +/- ##
===============================================
- Coverage 57.37% 57.27% -0.11%
===============================================
Files 211 211
Lines 27759 27736 -23
===============================================
- Hits 15927 15885 -42
- Misses 10202 10218 +16
- Partials 1630 1633 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
kishansagathiya
approved these changes
Feb 18, 2022
noot
approved these changes
Feb 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
encodingMusince it was a temporary fix I forgot to remove in fix(trie): memory leak fix inlib/trie#2009 as far as I recallTests
Issues
Done to test a comment after discussion with sigmap on Slack
Primary Reviewer