Skip to content

feat(lib/runtime): support Substrate WASM compression #2213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danforbes merged 4 commits into from
Jan 21, 2022
Merged

feat(lib/runtime): support Substrate WASM compression #2213

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
52e8f2a
Support Substrate Wasm compression
danforbes Jan 19, 2022
3abdd2b
Apply suggestions from code review
danforbes Jan 20, 2022
7482560
Review comments
danforbes Jan 21, 2022
53b35af
Apply suggestions from code review
danforbes Jan 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions lib/runtime/wasmer/instance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
package wasmer

import (
"bytes"
"errors"
"fmt"
"sync"
Expand All @@ -18,6 +19,8 @@ import (
"github.com/ChainSafe/gossamer/lib/crypto"

wasm "github.com/wasmerio/go-ext-wasm/wasmer"

"github.com/klauspost/compress/zstd"
Comment thread
kishansagathiya marked this conversation as resolved.
)

// Name represents the name of the interpreter
Expand Down Expand Up @@ -94,6 +97,22 @@ func NewInstance(code []byte, cfg *Config) (*Instance, error) {
return nil, errors.New("code is empty")
}

// Substrate Wasm compression
// https://github.com/paritytech/substrate/blob/master/primitives/maybe-compressed-blob/src/lib.rs
compressionFlag := []byte{82, 188, 83, 118, 70, 219, 142, 5}
Comment thread
danforbes marked this conversation as resolved.
Outdated
if bytes.HasPrefix(code, compressionFlag) {
logger.Debug("Decompressing Wasm runtime code")
Comment thread
kishansagathiya marked this conversation as resolved.
Outdated
var decoder, err = zstd.NewReader(nil)
Comment thread
danforbes marked this conversation as resolved.
Outdated
if err != nil {
return nil, errors.New("failed to create zstd decoder")
Comment thread
danforbes marked this conversation as resolved.
Outdated
}

code, err = decoder.DecodeAll(code[len(compressionFlag):], nil)
if err != nil {
return nil, errors.New("failed to decompress Wasm")
Comment thread
danforbes marked this conversation as resolved.
Outdated
}
}

logger.Patch(log.SetLevel(cfg.LogLvl), log.SetCallerFunc(true))

imports, err := cfg.Imports()
Expand Down