testing(lib/trie): change lib/trie slow and intensive benchmark-oriented tests to benchmarks#2031
Conversation
Codecov Report
@@ Coverage Diff @@
## development #2031 +/- ##
===============================================
+ Coverage 59.94% 60.10% +0.16%
===============================================
Files 185 193 +8
Lines 26343 26525 +182
===============================================
+ Hits 15790 15942 +152
- Misses 8677 8699 +22
- Partials 1876 1884 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
noot
left a comment
There was a problem hiding this comment.
is there a unit test for the parallel trie hashing? we should keep a unit test for it somewhere, but this change is fine
I'll add one in #2009 since I changed/improved the implementation for the parallel hashing. |
|
🎉 This PR is included in version 0.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
…ented tests to benchmarks (ChainSafe#2031) - Change unit tests to a merged Go benchmark (you can run them with `go test -bench`) - Use deepcopy to copy the trie instead of re-generating one, which takes time - Use math/rand instead of crypto/rand to generate trie values faster
Changes
t.Skip()themgo test -bench)Tests
Issues
Primary Reviewer