chore: Integrate scale package into lib/trie #1804
Merged
timwu20 merged 3 commits intodevelopmentfrom Sep 28, 2021
Merged
Conversation
timwu20
requested review from
EclesioMeloJunior,
arijitAD,
edwardmack,
jimjbrettj and
noot
as code owners
Codecov Report
@@ Coverage Diff @@
## development #1804 +/- ##
===============================================
- Coverage 59.57% 59.51% -0.07%
===============================================
Files 187 186 -1
Lines 19782 19724 -58
===============================================
- Hits 11785 11738 -47
+ Misses 5983 5982 -1
+ Partials 2014 2004 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
timwu20
force-pushed
the
tim-1750
branch
2 times, most recently
from
3c60752 to
3b4fb18
Compare
EclesioMeloJunior
approved these changes
Sep 24, 2021
noot
approved these changes
Sep 24, 2021
|
🎉 This PR is included in version 0.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
timwu20
added a commit
to timwu20/gossamer
that referenced
this pull request
Dec 6, 2021
* remove unused Encode/Decode * update scale integration * newHasher
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
lib/trie/Hasherto become privateTests
Issues
Primary Reviewer