Skip to content

lib/runtime: implement ext_local_storage_compare_and_set#1117

Merged
edwardmack merged 6 commits intodevelopmentfrom
ed/ext_local_storage_compare_and_set
Oct 3, 2020
Merged

lib/runtime: implement ext_local_storage_compare_and_set#1117
edwardmack merged 6 commits intodevelopmentfrom
ed/ext_local_storage_compare_and_set

Conversation

@edwardmack
Copy link
Copy Markdown
Contributor

@edwardmack edwardmack commented Oct 1, 2020

Changes

  • Implement ext function ext_local_storage_compare_and_set
  • Tests for ext_local_storage_compare_and_set

Tests

go test ./lib/runtime/...

Checklist

  • I have read CODE_OF_CONDUCT and CONTRIBUTING
  • I have provided as much information as possible and necessary
  • I have reviewed my own pull request before requesting a review
  • All integration tests and required coverage checks are passing

Issues

@edwardmack edwardmack self-assigned this Oct 1, 2020
@edwardmack edwardmack requested a review from noot October 1, 2020 23:12
Comment thread lib/runtime/runtime.go Outdated
var logger = log.New("pkg", "runtime")

// NodeStorageType type to identify offchain storage type
type NodeStorageType int32
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could by a byte?

Copy link
Copy Markdown
Contributor

@noot noot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@edwardmack edwardmack merged commit b4848c6 into development Oct 3, 2020
@edwardmack edwardmack deleted the ed/ext_local_storage_compare_and_set branch October 3, 2020 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants