Skip to content

lib/runtime: implement ext_network_state#1108

Merged
edwardmack merged 7 commits intodevelopmentfrom
ed/ext_network_state
Sep 28, 2020
Merged

lib/runtime: implement ext_network_state#1108
edwardmack merged 7 commits intodevelopmentfrom
ed/ext_network_state

Conversation

@edwardmack
Copy link
Copy Markdown
Contributor

@edwardmack edwardmack commented Sep 23, 2020

Changes

  • Implement function ext_network_state

Tests

go test ./lib/runtime/...

Checklist

  • I have read CODE_OF_CONDUCT and CONTRIBUTING
  • I have provided as much information as possible and necessary
  • I have reviewed my own pull request before requesting a review
  • All integration tests and required coverage checks are passing

Issues

Comment thread dot/core/service.go Outdated
Copy link
Copy Markdown
Contributor

@noot noot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work :)

Comment thread lib/runtime/test_helpers.go Outdated
@edwardmack edwardmack merged commit 2615560 into development Sep 28, 2020
@edwardmack edwardmack deleted the ed/ext_network_state branch September 28, 2020 15:04
@edwardmack edwardmack self-assigned this Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants