Skip to content

chore: butterflynet reset#7003

Merged
hanabi1224 merged 2 commits intomainfrom
hm/butterflynet-reset
May 5, 2026
Merged

chore: butterflynet reset#7003
hanabi1224 merged 2 commits intomainfrom
hm/butterflynet-reset

Conversation

@hanabi1224
Copy link
Copy Markdown
Contributor

@hanabi1224 hanabi1224 commented May 5, 2026

Summary of changes

Successful CI check: https://github.com/ChainSafe/forest/actions/runs/25374223480/job/74405101164#step:6:923

Set dummy upgrade epoch to 400, computed states from Forest and Lotus agree with each other

# Forest
2026-05-05T12:25:11.522629Z  WARN forest::chain_sync::tipset_syncer: Validating block [CID = bafy2bzacecgvq44kwmuau4yrtbpa4lbehcprnxdgxj7anq4wpij5m3qyihpxk, PARENT_STATE = bafy2bzaceanq6kpzlrnngiphljot3gnn6xkd5cofn4cuxalqthih4ae4prpww] in EPOCH = 402 failed: Validation error: Validation error: Parent state root did not match computed state: bafy2bzaceanq6kpzlrnngiphljot3gnn6xkd5cofn4cuxalqthih4ae4prpww (header), bafy2bzacedz4b5fr3da6ca6ywcnxvjcej4h4toex5ehkqazijgfhihsspz3yk (computed)

# Lotus
2026-05-05T20:25:30.314+0800    ERROR   chain   chain/sync.go:1007      failed to validate tipset: validating block bafy2bzacecgvq44kwmuau4yrtbpa4lbehcprnxdgxj7anq4wpij5m3qyihpxk:
    github.com/filecoin-project/lotus/chain.(*Syncer).ValidateTipSet.func1
        /home/me/git/lotus/chain/sync.go:603
  - 1 error occurred:
        * parent state root did not match computed state (bafy2bzaceanq6kpzlrnngiphljot3gnn6xkd5cofn4cuxalqthih4ae4prpww != bafy2bzacedz4b5fr3da6ca6ywcnxvjcej4h4toex5ehkqazijgfhihsspz3yk):
    github.com/filecoin-project/lotus/chain/consensus.CommonBlkChecks.func3
        /home/me/git/lotus/chain/consensus/common.go:119

Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

Summary by CodeRabbit

  • Chores
    • Finalized Butterflynet v18.0.0 release artifacts and updated network genesis parameters and download endpoints.
    • Updated bundle/manifest references so the network uses the finalized v18 actor set for synchronization and metadata.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 5, 2026

Walkthrough

Updated Butterflynet release artifacts and genesis references: manifest and actor CIDs for v18.0.0 were replaced, the actor bundle catalog now points to the v18.0.0 manifest CID, and Butterflynet genesis constants (GENESIS_CID, GENESIS_URL, GENESIS_URL_ALT) plus a FireHorse height mapping were updated.

Changes

Butterflynet release + genesis update

Layer / File(s) Summary
Manifest (actor CIDs & bundle)
build/manifest.json
butterflynet entry version changed from v18.0.0-rc1v18.0.0; bundle_cid, manifest.actors CIDs (system → datacap, eam, ethaccount), and actor_list_cid updated to new values.
Actor bundle catalog
src/networks/actors_bundle.rs
ACTOR_BUNDLES entry for butterflynet switched to use the v18.0.0 manifest CID (replacing the v18.0.0-rc1 CID).
Genesis constants
src/networks/butterflynet/mod.rs
GENESIS_CID replaced with new hard-coded CID; GENESIS_URL and GENESIS_URL_ALT updated to point to the new .car.zst artifacts and corresponding Lotus commit path.
Network height mapping
src/networks/butterflynet/mod.rs
HEIGHT_INFOS: FireHorse epoch mapping changed from height 960 with bundle v18.0.0-rc1 to height 1440 with bundle v18.0.0.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • ChainSafe/forest#6947: Modifies butterflynet artifacts and genesis identifiers (related manifest/GENESIS updates).
  • ChainSafe/forest#6047: Previously updated butterflynet GENESIS and actor bundle references in the same codepaths.

Suggested reviewers

  • sudo-shashank
  • LesnyRumcajs
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'chore: butterflynet reset' is vague and does not clearly convey the specific technical changes made. While it references 'butterflynet', it lacks detail about what 'reset' entails, and a developer scanning history would not understand that this updates genesis constants, manifest CIDs, and actor bundle versions to production v18.0.0. Consider a more descriptive title such as 'chore: update butterflynet genesis and v18.0.0 actor bundle' to better reflect the specific nature of the configuration updates.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch hm/butterflynet-reset
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch hm/butterflynet-reset

Comment @coderabbitai help to get the list of available commands and usage tips.

@hanabi1224 hanabi1224 marked this pull request as ready for review May 5, 2026 11:55
@hanabi1224 hanabi1224 requested a review from a team as a code owner May 5, 2026 11:55
@hanabi1224 hanabi1224 requested review from LesnyRumcajs and sudo-shashank and removed request for a team May 5, 2026 11:55
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/networks/butterflynet/mod.rs`:
- Line 46: Replace the .unwrap() call on the hard-coded CID returned by
Cid::from_str(...) with .expect("hard-coded CID must parse") to follow the
project's error-handling convention (matching GENESIS_URL/GENESIS_URL_ALT
usage); additionally, fix GENESIS_URL_ALT by either updating the embedded commit
hash e9eff3125a849bcc66bba3d0bddc64bce077698c to a commit that actually exists
in the filecoin-project/lotus repository or remove the GENESIS_URL_ALT fallback
entirely if you cannot verify a valid commit, ensuring the constant GENESIS_URL
remains the primary source.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 482ff0e6-e9d5-42c3-b18e-1ed2a59036b3

📥 Commits

Reviewing files that changed from the base of the PR and between 420a5ab and a65126c.

📒 Files selected for processing (1)
  • src/networks/butterflynet/mod.rs

Comment thread src/networks/butterflynet/mod.rs Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.12%. Comparing base (6979e17) to head (78fe39a).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/networks/butterflynet/mod.rs 60.00% 2 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
src/networks/actors_bundle.rs 90.30% <100.00%> (ø)
src/networks/butterflynet/mod.rs 71.26% <60.00%> (+0.33%) ⬆️

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6979e17...78fe39a. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hanabi1224 hanabi1224 force-pushed the hm/butterflynet-reset branch from a65126c to 8de262b Compare May 5, 2026 12:16
@hanabi1224 hanabi1224 enabled auto-merge May 5, 2026 13:04
@hanabi1224 hanabi1224 added this pull request to the merge queue May 5, 2026
Merged via the queue into main with commit a58b848 May 5, 2026
34 checks passed
@hanabi1224 hanabi1224 deleted the hm/butterflynet-reset branch May 5, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants