chore: butterflynet reset#7003
Conversation
WalkthroughUpdated Butterflynet release artifacts and genesis references: manifest and actor CIDs for v18.0.0 were replaced, the actor bundle catalog now points to the v18.0.0 manifest CID, and Butterflynet genesis constants (GENESIS_CID, GENESIS_URL, GENESIS_URL_ALT) plus a FireHorse height mapping were updated. ChangesButterflynet release + genesis update
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/networks/butterflynet/mod.rs`:
- Line 46: Replace the .unwrap() call on the hard-coded CID returned by
Cid::from_str(...) with .expect("hard-coded CID must parse") to follow the
project's error-handling convention (matching GENESIS_URL/GENESIS_URL_ALT
usage); additionally, fix GENESIS_URL_ALT by either updating the embedded commit
hash e9eff3125a849bcc66bba3d0bddc64bce077698c to a commit that actually exists
in the filecoin-project/lotus repository or remove the GENESIS_URL_ALT fallback
entirely if you cannot verify a valid commit, ensuring the constant GENESIS_URL
remains the primary source.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 482ff0e6-e9d5-42c3-b18e-1ed2a59036b3
📒 Files selected for processing (1)
src/networks/butterflynet/mod.rs
Codecov Report❌ Patch coverage is
Additional details and impacted files
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
a65126c to
8de262b
Compare
Summary of changes
Successful CI check: https://github.com/ChainSafe/forest/actions/runs/25374223480/job/74405101164#step:6:923
Set dummy upgrade epoch to 400, computed states from Forest and Lotus agree with each other
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes
Other information and links
Change checklist
Outside contributions
Summary by CodeRabbit