chore: bump rust toolchain to 1.95.0#6935
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughUpdated Rust toolchain to 1.95.0; migrated many tests from Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/utils/net/download_file.rs`:
- Line 383: The percent calculation currently does multiplication then
checked_div which risks overflow; update the computation of percent (using the
downloaded and total_size variables where percent is assigned) to first use
checked_mul(100) and then checked_div(total_size), preserving the final
unwrap_or(0) fallback so division-by-zero and overflow are both handled safely
(e.g., downloaded.checked_mul(100).and_then(|v|
v.checked_div(total_size)).unwrap_or(0)); change the assignment where percent is
computed in download_file.rs accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: f5effd13-c8cc-43bb-b27d-a614ecb0a447
📒 Files selected for processing (21)
rust-toolchain.tomlsrc/blocks/tipset.rssrc/cid_collections/hash_map.rssrc/cid_collections/mod.rssrc/cli/humantoken.rssrc/cli/subcommands/net_cmd.rssrc/db/car/forest/index/hash.rssrc/db/car/forest/index/mod.rssrc/db/gc/snapshot.rssrc/db/memory.rssrc/eth/transaction.rssrc/libp2p/discovery.rssrc/lotus_json/ipld.rssrc/lotus_json/mod.rssrc/lotus_json/opt.rssrc/lotus_json/raw_bytes.rssrc/lotus_json/vec.rssrc/rpc/methods/chain.rssrc/state_manager/mod.rssrc/tool/subcommands/net_cmd.rssrc/utils/net/download_file.rs
Codecov Report❌ Patch coverage is Additional details and impacted files
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes
Other information and links
Change checklist
Outside contributions
Summary by CodeRabbit
Chores
Refactor
Bug Fixes