Skip to content

chore: don't run snapshot export jobs on PRs#6852

Merged
LesnyRumcajs merged 2 commits intomainfrom
extract-snapshot-export-workflow
Apr 3, 2026
Merged

chore: don't run snapshot export jobs on PRs#6852
LesnyRumcajs merged 2 commits intomainfrom
extract-snapshot-export-workflow

Conversation

@LesnyRumcajs
Copy link
Copy Markdown
Member

@LesnyRumcajs LesnyRumcajs commented Apr 3, 2026

Summary of changes

To further speed up CI, let's extract snapshot tests out of PRs. Snapshot logic is seldom touched. We still run it on releases, daily and on demand.

Changes introduced in this pull request:

  • introduced Snapshot label to run strictly snapshot tests
  • don't run snapshot tests on PRs

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

Summary by CodeRabbit

Release Notes

  • Chores
    • Extended automated checks to trigger on both Release and Snapshot labels for broader test coverage
    • Optimized CI/CD job dependencies to improve workflow efficiency

@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner April 3, 2026 14:41
@LesnyRumcajs LesnyRumcajs requested review from akaladarshi and hanabi1224 and removed request for a team April 3, 2026 14:41
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 17e4912a-a25f-4d99-8c74-71c9f54a5f81

📥 Commits

Reviewing files that changed from the base of the PR and between ad24532 and 5b5c6c0.

📒 Files selected for processing (1)
  • .github/workflows/forest.yml

Walkthrough

Modified GitHub Actions workflow to expand calibnet export job triggers, now running on pull requests with either Release or Snapshot labels instead of just Release. Reorganized job dependencies: removed calibnet-export-check-v2 from integration-tests-status needs and added both v2 and diff-check jobs to extra_tests needs.

Changes

Cohort / File(s) Summary
Workflow Configuration
.github/workflows/forest.yml
Updated if conditions for calibnet-export checks to trigger on pull_request events with Release OR Snapshot labels; removed calibnet-export-check-v2 from integration-tests-status needs; extended extra_tests to depend on calibnet-export-check-v2 and calibnet-export-diff-check; formatted local-devnet-check.env comment inline.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • hanabi1224
  • akaladarshi
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: preventing snapshot export jobs from running on pull requests. It is concise, specific, and clearly summarizes the primary objective of the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch extract-snapshot-export-workflow
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch extract-snapshot-export-workflow

Comment @coderabbitai help to get the list of available commands and usage tips.

@LesnyRumcajs LesnyRumcajs added the Snapshot Run snapshot tests label Apr 3, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.92%. Comparing base (ad24532) to head (5b5c6c0).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

see 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad24532...5b5c6c0. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Apr 3, 2026
Merged via the queue into main with commit 45f66c3 Apr 3, 2026
39 of 63 checks passed
@LesnyRumcajs LesnyRumcajs deleted the extract-snapshot-export-workflow branch April 3, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Snapshot Run snapshot tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants