Skip to content

More cores coverage#6836

Merged
LesnyRumcajs merged 3 commits intomainfrom
more-cores-coverage
Apr 1, 2026
Merged

More cores coverage#6836
LesnyRumcajs merged 3 commits intomainfrom
more-cores-coverage

Conversation

@LesnyRumcajs
Copy link
Copy Markdown
Member

@LesnyRumcajs LesnyRumcajs commented Apr 1, 2026

Summary of changes

Let's try increasing the CPUs - warp dashboard showed we're CPU bound here, so we might possibly get the job in half the time for same amount of 💰

Changes introduced in this pull request:

  • re-used same profile for fetching snapshots (cuts down the subsequent step from 8 mins to 6 mins)
  • use twice the cores (cuts down time by ~30%)
  • dropped timeout to 30 mins

The job should complete now in ~13-14 mins vs 20-25 before.

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

Summary by CodeRabbit

  • Chores
    • Updated CI workflow to optimize the test execution environment and reduce job timeout.
    • Adjusted the test coverage step to run coverage instrumentation during test runs to produce accurate coverage data.

@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner April 1, 2026 11:58
@LesnyRumcajs LesnyRumcajs requested review from hanabi1224 and sudo-shashank and removed request for a team April 1, 2026 11:58
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 1, 2026

Walkthrough

Changed the Codecov GitHub Actions job: upgraded runner from warp-ubuntu-2404-arm64-4x to warp-ubuntu-2404-arm64-8x, reduced timeout-minutes from 45 to 30, and altered the coverage step to run cargo llvm-cov run --no-report ... instead of cargo run ... for the fetch step.

Changes

Cohort / File(s) Summary
CI Workflow Configuration
.github/workflows/coverage.yml
Updated runner label from warp-ubuntu-2404-arm64-4x to warp-ubuntu-2404-arm64-8x; reduced timeout-minutes from 45 to 30; replaced cargo run --bin ... invocation with cargo llvm-cov run --no-report --bin ... for the "Fetch proof params and RPC test snapshots" step while preserving flags and arguments.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • hanabi1224
  • sudo-shashank
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'More cores coverage' directly relates to the main change: increasing CPU cores for the coverage job from 4x to 8x to reduce runtime.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch more-cores-coverage
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch more-cores-coverage

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.84%. Comparing base (d52a294) to head (501d0d1).
⚠️ Report is 9 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

see 24 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d52a294...501d0d1. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sudo-shashank
sudo-shashank previously approved these changes Apr 1, 2026
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/coverage.yml:
- Line 48: The workflow change reduced timeout-minutes from 45 to 30 in the
coverage GitHub Actions workflow which is too aggressive; either revert
timeout-minutes back to 45 or set a conservative value like 40 in the
.github/workflows/coverage.yml (adjust the timeout-minutes key), and if keeping
30 provide and link empirical runtime data from several runs showing the
coverage job completes under 30 minutes with the increased cores so the change
is justified.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 52bb6afb-2e66-4a5b-ae42-c0e612288bea

📥 Commits

Reviewing files that changed from the base of the PR and between 72db485 and 501d0d1.

📒 Files selected for processing (1)
  • .github/workflows/coverage.yml

Comment thread .github/workflows/coverage.yml
@LesnyRumcajs LesnyRumcajs enabled auto-merge April 1, 2026 12:42
@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Apr 1, 2026
Merged via the queue into main with commit 70ca7af Apr 1, 2026
48 of 62 checks passed
@LesnyRumcajs LesnyRumcajs deleted the more-cores-coverage branch April 1, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants