More cores coverage#6836
Conversation
WalkthroughChanged the Codecov GitHub Actions job: upgraded runner from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted filessee 24 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/coverage.yml:
- Line 48: The workflow change reduced timeout-minutes from 45 to 30 in the
coverage GitHub Actions workflow which is too aggressive; either revert
timeout-minutes back to 45 or set a conservative value like 40 in the
.github/workflows/coverage.yml (adjust the timeout-minutes key), and if keeping
30 provide and link empirical runtime data from several runs showing the
coverage job completes under 30 minutes with the increased cores so the change
is justified.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 52bb6afb-2e66-4a5b-ae42-c0e612288bea
📒 Files selected for processing (1)
.github/workflows/coverage.yml
Summary of changes
Let's try increasing the CPUs -
warpdashboard showed we're CPU bound here, so we might possibly get the job in half the time for same amount of 💰Changes introduced in this pull request:
The job should complete now in ~13-14 mins vs 20-25 before.
Reference issue to close (if applicable)
Closes
Other information and links
Change checklist
Outside contributions
Summary by CodeRabbit