feat(rpc): add Forest.NetChainExchange for internal debugging#6824
Merged
hanabi1224 merged 2 commits intomainfrom Mar 31, 2026
Merged
feat(rpc): add Forest.NetChainExchange for internal debugging#6824hanabi1224 merged 2 commits intomainfrom
Forest.NetChainExchange for internal debugging#6824hanabi1224 merged 2 commits intomainfrom
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughAdds a new internal RPC method for chain exchange, exposes the chain-exchange handler, and makes the chain-exchange concurrency limit configurable via an environment variable; includes documentation and test-snapshot adjustments. Changes
Sequence DiagramsequenceDiagram
participant Client
participant RPC as Forest.NetChainExchange
participant ChainStore
participant SyncCtx as SyncNetworkContext
Client->>RPC: Forest.NetChainExchange(startTipsetKey?, len, options)
RPC->>RPC: Validate len > 0
alt startTipsetKey provided
RPC->>RPC: use provided key
else
RPC->>ChainStore: heaviest_tipset().key()
ChainStore-->>RPC: tipset key
end
RPC->>RPC: start timer
RPC->>SyncCtx: handle_chain_exchange_request(tipset_key, len)
SyncCtx->>SyncCtx: fetch tipsets (respecting concurrency limit)
SyncCtx-->>RPC: fetched tipsets count
RPC->>RPC: compute elapsed time
RPC-->>Client: "fetched N tipsets, took Xms"
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
hanabi1224
requested review from
LesnyRumcajs and
sudo-shashank
and removed request for
a team
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docs/docs/users/reference/env_variables.md (1)
66-66: Minor: Capitalize the description for consistency.Other entries in this table start with a capital letter (e.g., "The passphrase...", "Load CAR files...", "Maximum number of..."). Consider capitalizing for consistency:
-| `FOREST_MAX_CONCURRENT_CHAIN_EXCHANGE_REQUESTS` | positive integer | 3 | 3 | number of max concurrent requests to send over chain exchange protocol | +| `FOREST_MAX_CONCURRENT_CHAIN_EXCHANGE_REQUESTS` | positive integer | 3 | 3 | Maximum number of concurrent requests to send over the chain exchange protocol |🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/docs/users/reference/env_variables.md` at line 66, Update the table entry for the environment variable FOREST_MAX_CONCURRENT_CHAIN_EXCHANGE_REQUESTS by capitalizing the description text; replace "number of max concurrent requests to send over chain exchange protocol" with a capitalized phrase such as "Number of max concurrent requests to send over chain exchange protocol" (or improve to "Maximum number of concurrent requests to send over chain exchange protocol") to match the capitalization style of other entries.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@docs/docs/users/reference/env_variables.md`:
- Line 66: Update the table entry for the environment variable
FOREST_MAX_CONCURRENT_CHAIN_EXCHANGE_REQUESTS by capitalizing the description
text; replace "number of max concurrent requests to send over chain exchange
protocol" with a capitalized phrase such as "Number of max concurrent requests
to send over chain exchange protocol" (or improve to "Maximum number of
concurrent requests to send over chain exchange protocol") to match the
capitalization style of other entries.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 38a8d526-1ffc-4dda-9199-d456adb1e8bf
📒 Files selected for processing (4)
docs/docs/users/reference/env_variables.mdsrc/chain_sync/network_context.rssrc/rpc/methods/net.rssrc/rpc/mod.rs
Codecov Report❌ Patch coverage is
Additional details and impacted files
... and 10 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
sudo-shashank
approved these changes
Mar 31, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This was referenced Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Forest.NetChainExchangefor internal debuggingFOREST_MAX_CONCURRENT_CHAIN_EXCHANGE_REQUESTSConclusion:
Fetching 64 full tipsets is not much slower than fetching 64 tipset headers when max concurrency is updated to 3, not worth changing how the chain follower downloads tipsets.
Fetching full tipset:
{ "jsonrpc": "2.0", "method": "Forest.NetChainExchange", "params": [ [ { "/": "bafy2bzaceccdj25cza7ofkygmqqaesbsuy75hun2durwwngwqduiqz5fcpney" }, { "/": "bafy2bzacecxpe4pfypdx4f6z2hsy5tgvvra3loyprlupw7czrivfxf5adtsia" }, { "/": "bafy2bzacea2z5gachypsuldr7bynvmdnqohzdws7oni5y4uwnfqgxcthqkjqw" } ], 64, 3 ], "id": 123 }{ "jsonrpc": "2.0", "id": 123, "result": "fetched 64 tipsets, took 496ms 544us 847ns" }Fetching tipset headers:
{ "jsonrpc": "2.0", "method": "Forest.NetChainExchange", "params": [ [ { "/": "bafy2bzaceccdj25cza7ofkygmqqaesbsuy75hun2durwwngwqduiqz5fcpney" }, { "/": "bafy2bzacecxpe4pfypdx4f6z2hsy5tgvvra3loyprlupw7czrivfxf5adtsia" }, { "/": "bafy2bzacea2z5gachypsuldr7bynvmdnqohzdws7oni5y4uwnfqgxcthqkjqw" } ], 64, 1 ], "id": 123 }{ "jsonrpc": "2.0", "id": 123, "result": "fetched 64 tipsets, took 295ms 427us 572ns" }Reference issue to close (if applicable)
Closes
Other information and links
Change checklist
Outside contributions
Summary by CodeRabbit
New Features
Documentation
Tests