Skip to content

fix: add missing golden week entry in StateGetNetworkParams #6805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LesnyRumcajs merged 2 commits into from
Mar 26, 2026
Merged

fix: add missing golden week entry in StateGetNetworkParams #6805

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3542d12
fix: add missing golden week entry in `StateGetNetworkParams`
LesnyRumcajs Mar 26, 2026
4ea9c43
update insta snapshots
LesnyRumcajs Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@

### Fixed

- [#6707](https://github.com/ChainSafe/forest/issues/6707): Added missing `GoldenWeek` network upgrade entry in `Filecoin.StateGetNetworkParams` RPC method.

## Forest v0.32.4 "Mild Inconvenience"

This is a non-mandatory release for all node operators. It enables F3 finality resolution on ETH v1 RPC methods.
Expand Down
4 changes: 2 additions & 2 deletions src/rpc/methods/state.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3142,7 +3142,7 @@ pub struct ForkUpgradeParams {
upgrade_tuktuk_height: ChainEpoch,
upgrade_teep_height: ChainEpoch,
upgrade_tock_height: ChainEpoch,
//upgrade_golden_week_height: ChainEpoch,
upgrade_golden_week_height: ChainEpoch,
//upgrade_xxx_height: ChainEpoch,
}

Expand Down Expand Up @@ -3191,7 +3191,7 @@ impl TryFrom<&ChainConfig> for ForkUpgradeParams {
upgrade_tuktuk_height: get_height(TukTuk)?,
upgrade_teep_height: get_height(Teep)?,
upgrade_tock_height: get_height(Tock)?,
//upgrade_golden_week_height: get_height(GoldenWeek)?,
upgrade_golden_week_height: get_height(GoldenWeek)?,
//upgrade_xxx_height: get_height(Xxx)?,
})
}
Expand Down
4 changes: 4 additions & 0 deletions src/rpc/snapshots/forest__rpc__tests__rpc__v0.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions src/rpc/snapshots/forest__rpc__tests__rpc__v1.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/tool/subcommands/api_cmd/test_snapshots.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ filecoin_stategetbeaconentry_1737546933208724.rpcsnap.json.zst
filecoin_stategetclaim_1737546933208940.rpcsnap.json.zst
filecoin_stategetclaims_1737546933208977.rpcsnap.json.zst
filecoin_stategetid_1764943126105310.rpcsnap.json.zst
filecoin_stategetnetworkparams_1756890287572001.rpcsnap.json.zst
filecoin_stategetnetworkparams_1774522153615694.rpcsnap.json.zst
Comment thread
LesnyRumcajs marked this conversation as resolved.
filecoin_stategetrandomnessdigestfrombeacon_1737546933236534.rpcsnap.json.zst
filecoin_stategetrandomnessdigestfromtickets_1737546933236558.rpcsnap.json.zst
filecoin_stategetrandomnessfrombeacon_1737546933236581.rpcsnap.json.zst
Expand Down
Loading