Skip to content

chore: make tokio console optional#6680

Merged
hanabi1224 merged 1 commit intomainfrom
tokio-console-optional
Mar 3, 2026
Merged

chore: make tokio console optional#6680
hanabi1224 merged 1 commit intomainfrom
tokio-console-optional

Conversation

@LesnyRumcajs
Copy link
Copy Markdown
Member

@LesnyRumcajs LesnyRumcajs commented Mar 3, 2026

Summary of changes

Changes introduced in this pull request:

This cuts binary size from 101 MB to 99 MB

  • made tokio-console optional dependency, disabled by default

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

Summary by CodeRabbit

  • Breaking Changes
    • tokio-console is now optional and disabled by default. Users who need this feature must compile with --features tokio-console.

@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner March 3, 2026 10:01
@LesnyRumcajs LesnyRumcajs requested review from hanabi1224 and sudo-shashank and removed request for a team March 3, 2026 10:01
@LesnyRumcajs LesnyRumcajs force-pushed the tokio-console-optional branch from 8153629 to e9af851 Compare March 3, 2026 10:03
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bad9cb1 and e9af851.

📒 Files selected for processing (2)
  • CHANGELOG.md
  • Cargo.toml

Walkthrough

The changes make tokio-console an optional feature disabled by default, requiring explicit compilation with the --features tokio-console flag to enable it. The CHANGELOG documents this breaking change to user-facing behavior and build requirements.

Changes

Cohort / File(s) Summary
Feature Configuration and Documentation
CHANGELOG.md, Cargo.toml
Removed tokio-console from the default feature set in Cargo.toml and added a breaking change entry in CHANGELOG.md documenting that tokio-console is now optional and must be explicitly enabled via compilation flags.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Suggested reviewers

  • sudo-shashank
  • hanabi1224
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: make tokio console optional' directly and clearly describes the main change in the pull request: making the tokio-console dependency optional and disabled by default.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch tokio-console-optional

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.53%. Comparing base (bad9cb1) to head (e9af851).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bad9cb1...e9af851. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hanabi1224 hanabi1224 added this pull request to the merge queue Mar 3, 2026
Merged via the queue into main with commit 875dcec Mar 3, 2026
43 checks passed
@hanabi1224 hanabi1224 deleted the tokio-console-optional branch March 3, 2026 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants