Skip to content

fix(test): unfilter Filecoin.EthSyncing for lotus-gateway API compare test#6638

Merged
hanabi1224 merged 1 commit intomainfrom
hm/unfilter-ethsyncing-gateway
Feb 23, 2026
Merged

fix(test): unfilter Filecoin.EthSyncing for lotus-gateway API compare test#6638
hanabi1224 merged 1 commit intomainfrom
hm/unfilter-ethsyncing-gateway

Conversation

@hanabi1224
Copy link
Copy Markdown
Contributor

@hanabi1224 hanabi1224 commented Feb 23, 2026

Summary of changes

The fix has been included in lotus@v1.35.0 release: https://github.com/filecoin-project/lotus/releases/tag/v1.35.0

Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

Summary by CodeRabbit

  • Tests
    • Updated API support status: EthSyncing is now supported, EthGetFilterLogs marked as unsupported.

@hanabi1224 hanabi1224 added the RPC requires calibnet RPC checks to run on CI label Feb 23, 2026
@hanabi1224 hanabi1224 marked this pull request as ready for review February 23, 2026 08:09
@hanabi1224 hanabi1224 requested a review from a team as a code owner February 23, 2026 08:09
@hanabi1224 hanabi1224 requested review from LesnyRumcajs and akaladarshi and removed request for a team February 23, 2026 08:09
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 23, 2026

Walkthrough

This pull request modifies the gateway API test filter list by marking the EthGetFilterLogs method as broken and removing EthSyncing from the broken category, updating the test expectations for these methods.

Changes

Cohort / File(s) Summary
Test Filter Configuration
scripts/tests/api_compare/filter-list-gateway
Marked Filecoin.EthGetFilterLogs as broken and removed Filecoin.EthSyncing from the broken list.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • LesnyRumcajs
  • akaladarshi
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing EthSyncing from the broken/filtered list in the API compare test configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch hm/unfilter-ethsyncing-gateway

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.33%. Comparing base (108bf3e) to head (dba925d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

see 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 108bf3e...dba925d. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hanabi1224 hanabi1224 enabled auto-merge February 23, 2026 08:27
@hanabi1224 hanabi1224 added this pull request to the merge queue Feb 23, 2026
Merged via the queue into main with commit cc869f5 Feb 23, 2026
39 of 64 checks passed
@hanabi1224 hanabi1224 deleted the hm/unfilter-ethsyncing-gateway branch February 23, 2026 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RPC requires calibnet RPC checks to run on CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants