Skip to content

fix: foreign network wallet listing #6555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LesnyRumcajs merged 1 commit into from
Feb 7, 2026
Merged

fix: foreign network wallet listing #6555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,8 @@

- [#6541](https://github.com/ChainSafe/forest/pull/6541): Fixed "actor not found" errors when running Foundry (forge) scripts. The `eth_getBalance`, `eth_getTransactionCount`, and `eth_getCode` methods now return default values (0 balance, 0 nonce, empty code) for non-existent addresses, matching Lotus and standard Ethereum behavior.

- [#6555](https://github.com/ChainSafe/forest/pull/6555): Fixed listing of wallets belonging to different networks in `forest-wallet list` command (and the `Filecoin.WalletList` RPC method). This incorrectly showed, e.g., calibnet wallets when running a mainnet node. Under the hood they're actually the same, but this could cause confusion and issues with some clients. It also resulted in errors trying to export a wallet that belongs to a different network.

## Forest v0.31.1 "Quadrantids"

This is a non-mandatory release for all node operators. It includes the support for more V2 API's and a few critical API fixes.
Expand Down
4 changes: 2 additions & 2 deletions src/key_management/wallet.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,9 +180,9 @@ pub fn list_addrs(keystore: &KeyStore) -> Result<Vec<Address>, Error> {
let mut out = Vec::new();
for i in all {
if let Some(addr_str) = i.strip_prefix("wallet-")
&& let Ok(addr) = Address::from_str(addr_str)
&& let Ok(addr) = crate::shim::address::StrictAddress::from_str(addr_str)
{
out.push(addr);
out.push(addr.into());
}
}
Ok(out)
Expand Down
Loading