Skip to content

Improve log for stateful API check #6497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sudo-shashank merged 2 commits into from
Jan 29, 2026
Merged

Improve log for stateful API check #6497

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b7687d
more logs
sudo-shashank Jan 28, 2026
3061a17
Merge branch 'main' into shashank/log-stateful-api
sudo-shashank Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions src/tool/subcommands/api_cmd/stateful_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,19 +521,25 @@ fn eth_new_pending_transaction_filter(tx: TestTransaction) -> RpcTestScenario {
.await?;

if let EthFilterResult::Hashes(hashes) = filter_result {
anyhow::ensure!(prev_hashes != hashes);
anyhow::ensure!(
prev_hashes != hashes,
"prev_hashes={prev_hashes:?} hashes={hashes:?}"
);

let mut cids = vec![];
for hash in hashes {
for hash in &hashes {
if let Some(cid) = client
.call(EthGetMessageCidByTransactionHash::request((hash,))?)
.call(EthGetMessageCidByTransactionHash::request((hash.clone(),))?)
.await?
{
cids.push(cid);
}
}

anyhow::ensure!(cids.contains(&cid));
anyhow::ensure!(
cids.contains(&cid),
"CID missing from filter results: cid={cid:?} cids={cids:?} hashes={hashes:?}"
);

Ok(())
} else {
Expand Down Expand Up @@ -594,9 +600,7 @@ fn eth_get_filter_logs(tx: TestTransaction) -> RpcTestScenario {
let result = if let EthFilterResult::Logs(logs) = filter_result {
anyhow::ensure!(
!logs.is_empty(),
"Empty logs: filter_spec={:?} cid={}",
filter_spec,
cid
"Empty logs: filter_spec={filter_spec:?} cid={cid:?}",
);
Ok(())
} else {
Expand Down
Loading