Skip to content

fix(f3): pin crypto@v0.43.0#6485

Merged
hanabi1224 merged 1 commit intomainfrom
hm/pin-crypto-in-f3
Jan 27, 2026
Merged

fix(f3): pin crypto@v0.43.0#6485
hanabi1224 merged 1 commit intomainfrom
hm/pin-crypto-in-f3

Conversation

@hanabi1224
Copy link
Copy Markdown
Contributor

@hanabi1224 hanabi1224 commented Jan 27, 2026

Summary of changes

Pin crypto@0.43.0 as it removed some assembly optimizations since v0.44.0. See filecoin-project/go-f3#1063 (comment) for details

Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Summary by CodeRabbit

  • Chores
    • Updated project dependencies to maintain compatibility and stability.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 27, 2026

Walkthrough

The pull request updates multiple Go module dependency versions in the f3-sidecar/go.mod file, downgrading or adjusting versions for packages including libp2p/go-libp2p-kad-dht, golang.org/x/crypto, github.com/miekg/dns, and several golang.org/x/\* packages.

Changes

Cohort / File(s) Summary
Go Module Dependency Updates
f3-sidecar/go.mod
Downgraded or adjusted versions across 10 dependency entries, including libp2p/go-libp2p-kad-dht (v0.37.0 → v0.35.1), golang.org/x/crypto (v0.47.0 → v0.43.0), github.com/miekg/dns (v1.1.69 → v1.1.68), and multiple golang.org/x/\* packages (exp, mod, net, telemetry, text, tools).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~4 minutes

Possibly related PRs

Suggested reviewers

  • sudo-shashank
  • LesnyRumcajs
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: pinning the crypto dependency to v0.43.0, which aligns with the primary modification in the go.mod file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.5.0)

level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain modules listed in go.work or their selected dependencies"


Comment @coderabbitai help to get the list of available commands and usage tips.

@hanabi1224 hanabi1224 marked this pull request as ready for review January 27, 2026 11:34
@hanabi1224 hanabi1224 requested a review from a team as a code owner January 27, 2026 11:34
@hanabi1224 hanabi1224 requested review from LesnyRumcajs and akaladarshi and removed request for a team January 27, 2026 11:34
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@f3-sidecar/go.mod`:
- Line 18: Replace the pinned dependency golang.org/x/crypto v0.43.0 in go.mod
with at least v0.45.0 to include fixes for the SSH CVEs (CVE-2025-58181 and
CVE-2025-47914), and update or remove the accompanying comment about assembly
optimizations/commit cf29fa96f8b66328e59829f064539321159bfa5b to reflect that
SHA-3 is delegated to crypto/sha3 (Go 1.24+) and that the security-fix upgrade
should be used unless a documented, measured performance regression is proven
for this codebase.

Comment thread f3-sidecar/go.mod
@hanabi1224 hanabi1224 enabled auto-merge January 27, 2026 11:54
@hanabi1224 hanabi1224 added this pull request to the merge queue Jan 27, 2026
Merged via the queue into main with commit c32dd7c Jan 27, 2026
40 checks passed
@hanabi1224 hanabi1224 deleted the hm/pin-crypto-in-f3 branch January 27, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants