chore: use derive_more::FromStr#6476
Conversation
WalkthroughThe PR refactors FromStr trait implementations for EthAddress and EthHash by switching from manual implementations to derived implementations using derive_more::FromStr. Error handling in EthTraceTransaction is enhanced with contextual error messaging for invalid transaction hashes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files
... and 36 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Summary of changes
Changes introduced in this pull request:
derive_more::FromStrReference issue to close (if applicable)
Closes
Other information and links
Change checklist
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.