-
Notifications
You must be signed in to change notification settings - Fork 196
fix(test): speed up test-release and codecov on CI #6372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
e496b3f
5a8675d
afa58f3
45f74a8
80b2f2e
6ad6456
9425181
4edf480
73b3d8f
0eb2812
00f0d72
a74c99c
284ec79
836b7a2
89ba6d9
f63bdc1
b5de8d1
7ea16b7
f136bdd
f3dae30
d056b6a
c0d2813
400b88e
fb1eb32
a208961
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -115,7 +115,7 @@ test-release-docs: | |
| cargo test --profile quick --doc --features doctest-private | ||
|
|
||
| codecov: | ||
| cargo llvm-cov --workspace --codecov --output-path lcov.info | ||
| cargo llvm-cov -p forest-filecoin --no-default-features --codecov --output-path lcov.info | ||
|
LesnyRumcajs marked this conversation as resolved.
Outdated
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shouldn't we run tests with same features (and thus code paths) that the actual binary runs with?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @LesnyRumcajs Restored |
||
|
|
||
| # Checks if all headers are present and adds if not | ||
| license: | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be faster to fetch them via docker? I don't think there's a need to compile it unless we're reusing the same compilation units in the codecov stage compilation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, I can switch to docker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It turns out that fetching only parameter files is insufficient, we need to pre-fetch RPC test snapshots as well to save time and reduce flakyness. Switched to
forest-devsolution.