Skip to content

fix eth_get_filter_logs test #6363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sudo-shashank merged 5 commits into from
Dec 19, 2025
Merged

fix eth_get_filter_logs test #6363

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d048a8d
fix eth_get_filter_logs
sudo-shashank Dec 18, 2025
5a1b3f3
Merge branch 'main' into shashank/get-filter-logs-test-fix
sudo-shashank Dec 18, 2025
9fe79ef
Merge branch 'main' into shashank/get-filter-logs-test-fix
sudo-shashank Dec 18, 2025
4852965
lint fix
sudo-shashank Dec 18, 2025
3ee0550
Merge branch 'main' into shashank/get-filter-logs-test-fix
sudo-shashank Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 4 additions & 29 deletions src/tool/subcommands/api_cmd/stateful_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ impl RpcTestScenario {
self
}

fn ignore(mut self, msg: &'static str) -> Self {
fn _ignore(mut self, msg: &'static str) -> Self {
self.ignore = Some(msg);
self
}
Expand Down Expand Up @@ -567,51 +567,28 @@ fn eth_get_filter_logs(tx: TestTransaction) -> RpcTestScenario {
const BLOCK_RANGE: u64 = 1;

let tipset = client.call(ChainHead::request(())?).await?;

let encoded = cbor4ii::serde::to_vec(
Vec::with_capacity(tx.payload.len()),
&Value::Bytes(tx.payload.clone()),
)
.context("failed to encode params")?;

let message = Message {
to: tx.to,
from: tx.from,
method_num: EVMMethod::InvokeContract as u64,
params: encoded.into(),
..Default::default()
};

let smsg = client
.call(MpoolPushMessage::request((message, None))?)
.await?;

let cid = invoke_contract(&client, &tx).await?;
let lookup = client
.call(
StateWaitMsg::request((smsg.cid(), 0, tipset.epoch(), false))?
StateWaitMsg::request((cid, 0, tipset.epoch(), false))?
.with_timeout(Duration::from_secs(300)),
)
.await?;

let block_num = EthUint64(lookup.height as u64);

let topics = EthTopicSpec(vec![EthHashList::Single(Some(tx.topic))]);

let filter_spec = EthFilterSpec {
from_block: Some(format!("0x{:x}", block_num.0.saturating_sub(BLOCK_RANGE))),
to_block: Some(block_num.to_hex_string()),
topics: Some(topics),
..Default::default()
};

let filter_id = client.call(EthNewFilter::request((filter_spec,))?).await?;

let filter_result = as_logs(
client
.call(EthGetFilterLogs::request((filter_id.clone(),))?)
.await?,
);

let result = if let EthFilterResult::Logs(logs) = filter_result {
anyhow::ensure!(!logs.is_empty());
Ok(())
Expand Down Expand Up @@ -680,9 +657,7 @@ pub(super) async fn create_tests(tx: TestTransaction) -> Vec<RpcTestScenario> {
EthUninstallFilter
),
with_methods!(
eth_get_filter_logs(tx.clone())
.name("eth_getFilterLogs works")
.ignore("https://github.com/ChainSafe/forest/issues/5917"),
eth_get_filter_logs(tx.clone()).name("eth_getFilterLogs works"),
EthNewFilter,
EthGetFilterLogs,
EthUninstallFilter
Expand Down
Loading