-
Notifications
You must be signed in to change notification settings - Fork 188
feat: add prometheus metrics network_version and actor_version
#6079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ed05df0
feat: add prometheus metrics `network_height` and `network_version`
hanabi1224 d1c8129
changelog
hanabi1224 7eda899
fix GC
hanabi1224 3537f0d
update docs
hanabi1224 c49a095
Merge remote-tracking branch 'origin/main' into hm/metric-network-ver…
hanabi1224 4a5eb4f
network_version_revision
hanabi1224 3b5bd97
update docs
hanabi1224 1bea7fe
reset prometheus registry after GC
hanabi1224 2be478f
add actor_version metrics
hanabi1224 41a80d7
Merge remote-tracking branch 'origin/main' into hm/metric-network-ver…
hanabi1224 9965521
revert metrics registry reset changes
hanabi1224 821be7d
collect "head_epoch" metrics with collector
hanabi1224 5e3c574
Merge remote-tracking branch 'origin/main' into hm/metric-network-ver…
hanabi1224 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
LGTM: import cleanup matches HEAD_EPOCH removal
No stray Gauge usage here. Please confirm no remaining references to HEAD_EPOCH across the repo.
🏁 Script executed:
Length of output: 188
HEAD_EPOCH references remain — remove or justify
Found in scripts/tests/calibnet_eth_mapping_check.sh:19–20 (HEAD_EPOCH=$(...) and EPOCH=$((HEAD_EPOCH - 1))). Remove or document why this reference must remain.
🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HEAD_EPOCHin the script is extracted fromforest-cli info showoutput which is irrelevant to the metricsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hanabi1224 You're absolutely right - thank you for the clarification! The
HEAD_EPOCHin the shell scriptscripts/tests/calibnet_eth_mapping_check.shis indeed a shell variable extracted fromforest-cli info showoutput, which is completely unrelated to the Rust metricsHEAD_EPOCHconstant that was removed fromsrc/chain_sync/metrics.rs.My analysis incorrectly flagged this as a potential issue when it's actually a legitimate usage in a different context. The script usage is fine and should remain as-is.
✏️ Learnings added
🧠 Learnings used