chore: remove deprecated forest-cli send

[LesnyRumcajs]

Summary of changes

Changes introduced in this pull request:

• the forest-cli send subcommand was deprecated in April 2024. Time to get rid of it.

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

• I have performed a self-review of my own code,
• I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
• I have added tests that prove my fix is effective or that my feature works (if possible),
• I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Summary by CodeRabbit

• Chores

  • Removed the deprecated forest-cli send subcommand; use forest-wallet send for transactions.

• Documentation

  • Updated the changelog to document the send subcommand removal and point users to forest-wallet send.

• Notes for Users

  • No other CLI behavior changed. Migrate any workflows relying on forest-cli send to forest-wallet send.

[coderabbitai]

Walkthrough

Removed the deprecated CLI "send" subcommand from the codebase: deleted its module/file, removed the Send enum variant and dispatch arm, and updated the changelog to direct users to forest-wallet send. No other code or behavior was changed.

Changes

Cohort / File(s)	Summary
CLI subcommand removal src/cli/subcommands/mod.rs, src/cli/main.rs	Deleted the Send variant from Subcommand, removed the send_cmd module and its re-export, and removed the Subcommand::Send dispatch arm from main CLI dispatch.
File deletion: send command src/cli/subcommands/send_cmd.rs	Removed the entire SendCommand implementation (Clap args, run method, RPC/mempool push logic and deprecation notice).
Changelog update CHANGELOG.md	Added entry documenting removal of deprecated forest-cli send and guidance to use forest-wallet send instead; removed two unrelated prior "Removed" lines.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant CLI as forest-cli
  participant RPC as Node RPC

  rect rgba(200,230,255,0.25)
    note over User,CLI: Previous (before this change)
    User->>CLI: forest-cli send --to ... --amount ...
    CLI->>RPC: MpoolPushMessage(Message)
    RPC-->>CLI: CID
    CLI-->>User: Print CID
  end

Loading

sequenceDiagram
  autonumber
  actor User
  participant CLI as forest-cli

  rect rgba(255,220,200,0.25)
    note over User,CLI: Current (after this change)
    User->>CLI: forest-cli send ...
    CLI-->>User: Subcommand not found / unsupported
    note over User,CLI: Use forest-wallet send instead
  end

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• feat: strict checks for address args in forest-cli #6011 — Updates CLI subcommands (including send) to use StrictAddress types; touches related CLI send code and parsing.

Suggested reviewers

• hanabi1224
• akaladarshi
• elmattic

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 1969f4a and c268a2c.

📒 Files selected for processing (2)

• CHANGELOG.md (1 hunks)
• src/cli/main.rs (0 hunks)

💤 Files with no reviewable changes (1)

• src/cli/main.rs

✅ Files skipped from review due to trivial changes (1)

• CHANGELOG.md

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)

• GitHub Check: Build forest binaries on Linux AMD64
• GitHub Check: cargo-publish-dry-run
• GitHub Check: Build MacOS
• GitHub Check: Build Ubuntu
• GitHub Check: Check
• GitHub Check: Analyze (go)
• GitHub Check: Analyze (python)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch remove-deprecated-cli-send

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 15cdbb3 and 1969f4a.

📒 Files selected for processing (4)

• CHANGELOG.md (1 hunks)
• src/cli/main.rs (0 hunks)
• src/cli/subcommands/mod.rs (1 hunks)
• src/cli/subcommands/send_cmd.rs (0 hunks)

💤 Files with no reviewable changes (2)

• src/cli/main.rs
• src/cli/subcommands/send_cmd.rs

🧰 Additional context used

🧠 Learnings (1)

📓 Common learnings

Learnt from: LesnyRumcajs
PR: ChainSafe/forest#5907
File: src/rpc/methods/state.rs:523-570
Timestamp: 2025-08-06T15:44:33.467Z
Learning: LesnyRumcajs prefers to rely on BufWriter's Drop implementation for automatic flushing rather than explicit flush() calls in Forest codebase.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)

• GitHub Check: tests
• GitHub Check: tests-release
• GitHub Check: Build forest binaries on Linux AMD64
• GitHub Check: cargo-publish-dry-run
• GitHub Check: Build Ubuntu
• GitHub Check: All lint checks
• GitHub Check: Analyze (go)
• GitHub Check: Analyze (rust)