Skip to content

fix(test): increase nextest timeout for rpc snapshot tests#5945

Merged
hanabi1224 merged 1 commit intomainfrom
hm/increase-timeout-for-rpc-snap-tests
Aug 18, 2025
Merged

fix(test): increase nextest timeout for rpc snapshot tests#5945
hanabi1224 merged 1 commit intomainfrom
hm/increase-timeout-for-rpc-snap-tests

Conversation

@hanabi1224
Copy link
Copy Markdown
Contributor

@hanabi1224 hanabi1224 commented Aug 18, 2025

Summary of changes

This PR increases nextest timeout for rpc snapshot tests to mitigate CI failures like https://github.com/ChainSafe/forest/actions/runs/17035137824/job/48285775210#step:7:2562

Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Summary by CodeRabbit

  • Tests
    • Updated test configuration to better accommodate slow, network-dependent test cases, reducing flakiness by extending timeouts and adjusting termination thresholds. This improves CI stability and test reliability without affecting product behavior for end-users.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Aug 18, 2025

Walkthrough

Adds a Nextest override to .config/nextest.toml for tests matching rpc_test_*, setting slow-timeout to 120s and terminate-after to 3, with a comment explaining these tests fetch snapshots from the network. No existing settings are modified.

Changes

Cohort / File(s) Summary
Test configuration
​.config/nextest.toml
Added a profile.default.overrides entry for rpc_test_* with slow-timeout = 120s and terminate-after = 3; included explanatory comment.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • elmattic
  • sudo-shashank
  • LesnyRumcajs

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between b9ed919 and 3e55959.

📒 Files selected for processing (1)
  • .config/nextest.toml (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: hanabi1224
PR: ChainSafe/forest#5930
File: build.rs:64-77
Timestamp: 2025-08-13T09:43:20.301Z
Learning: hanabi1224 prefers hard compile-time errors in build scripts rather than runtime safeguards or collision detection, believing it's better to fail fast and fix root causes of issues like malformed snapshot names.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
  • GitHub Check: tests-release
  • GitHub Check: tests
  • GitHub Check: Build forest binaries on Linux AMD64
  • GitHub Check: All lint checks
  • GitHub Check: Build Ubuntu
  • GitHub Check: cargo-publish-dry-run
  • GitHub Check: Build MacOS
  • GitHub Check: Analyze (rust)
  • GitHub Check: Analyze (go)
🔇 Additional comments (1)
.config/nextest.toml (1)

37-40: Verify integration-test binary filter matches actual test binaries

The repository search didn’t reveal any rpc_test_*.rs files under typical integration paths, so switching to binary(rpc_test_) as-is may end up matching nothing. Please confirm your integration-test binary names:

cargo nextest list --profile default | rg rpc_test_

Then update the override and its comment in .config/nextest.toml (lines 37–40) to reflect the actual binary naming. For example:

-# Integration-test binaries named `rpc_test_*` download test snapshots from the network, which can take a while.
+# Integration tests download test snapshots from the network; ensure this filter matches your binary names (e.g., `rpc_test_*`).
 [[profile.default.overrides]]
-filter = 'binary(rpc_test_)'
+filter = 'binary(rpc_test_)'
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch hm/increase-timeout-for-rpc-snap-tests

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@hanabi1224 hanabi1224 marked this pull request as ready for review August 18, 2025 09:54
@hanabi1224 hanabi1224 requested a review from a team as a code owner August 18, 2025 09:54
@hanabi1224 hanabi1224 requested review from LesnyRumcajs and sudo-shashank and removed request for a team August 18, 2025 09:54
@hanabi1224 hanabi1224 enabled auto-merge August 18, 2025 10:00
@hanabi1224 hanabi1224 added this pull request to the merge queue Aug 18, 2025
Merged via the queue into main with commit 72262eb Aug 18, 2025
48 checks passed
@hanabi1224 hanabi1224 deleted the hm/increase-timeout-for-rpc-snap-tests branch August 18, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants