Skip to content

chore: use buildjet ubuntu in calibnet rpc check ci #5878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LesnyRumcajs merged 1 commit into from
Jul 31, 2025
Merged

chore: use buildjet ubuntu in calibnet rpc check ci #5878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/forest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,7 @@ jobs:
needs:
- build-ubuntu
name: Calibnet RPC checks
runs-on: ubuntu-24.04
runs-on: buildjet-8vcpu-ubuntu-2204
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Same runner-label issue as above—keep the workflows consistent.

Replicate the fix (either self-hosted prefix or actionlint.yaml entry) here to prevent linter noise and accidental runner mismatch:

-    runs-on: buildjet-8vcpu-ubuntu-2204
+    runs-on: [self-hosted, buildjet-8vcpu-ubuntu-2204]

While you are touching this, ensure the BuildJet runner pool has Docker privileged mode enabled—steps 527-534 rely on root access to /var/lib/docker.

🏁 Script executed:

#!/bin/bash
# Show context around the specific runs-on entry in forest.yml
grep -n "runs-on:.*buildjet-8vcpu-ubuntu-2204" .github/workflows/forest.yml | while IFS=: read -r file line _; do
  echo "⮑ $file:$line"
  sed -n "$((line-2)),$((line+2))p" "$file"
done

# List all runs-on usages across workflows to verify consistency
echo
echo "=== All runs-on labels in .github/workflows ==="
rg "runs-on:" -n .github/workflows

# Check for an actionlint.yaml to see if the runner-label mapping is configured there
echo
echo "=== Searching for actionlint.yaml ==="
fd actionlint.yaml

Length of output: 6275

🏁 Script executed:

#!/bin/bash
# Correctly extract lines 520-550 around the runs-on entry and subsequent steps
sed -n '520,550p' .github/workflows/forest.yml

# Search for references to /var/lib/docker to confirm Docker dind usage
grep -n '/var/lib/docker' .github/workflows/forest.yml || true

Length of output: 1553

Add self-hosted prefix to the BuildJet runner and verify Docker privileged mode

Please update your Calibnet RPC checks in .github/workflows/forest.yml to explicitly mark it as a self-hosted runner and ensure the pool is running with Docker privileged mode enabled (since you’re relocating /var/lib/docker in steps 528–533).

• File: .github/workflows/forest.yml line 522
• Replace:

-    runs-on: buildjet-8vcpu-ubuntu-2204
+    runs-on: [self-hosted, buildjet-8vcpu-ubuntu-2204]

• Confirm with your infra team that the BuildJet runner pool has privileged: true (or equivalent) so that sudo mv /var/lib/docker/… and related commands succeed.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
runs-on: buildjet-8vcpu-ubuntu-2204
runs-on: [self-hosted, buildjet-8vcpu-ubuntu-2204]
🧰 Tools
🪛 actionlint (1.7.7)

522-522: label "buildjet-8vcpu-ubuntu-2204" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file

(runner-label)

🤖 Prompt for AI Agents 
In .github/workflows/forest.yml at line 522, update the runner label to include
the 'self-hosted' prefix by changing 'runs-on: buildjet-8vcpu-ubuntu-2204' to
'runs-on: [self-hosted, buildjet-8vcpu-ubuntu-2204]'. Additionally, confirm with
the infrastructure team that the runner pool is configured with Docker
privileged mode enabled (e.g., 'privileged: true') to allow commands like 'sudo
mv /var/lib/docker/…' to execute successfully.

env:
# We use a custom Dockerfile for CI to speed up the build process.
FOREST_DOCKERFILE_OVERRIDE: scripts/devnet/forest_ci.dockerfile
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/rpc-parity.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
jobs:
rpc-parity:
name: RPC parity tests
runs-on: ubuntu-24.04
runs-on: buildjet-8vcpu-ubuntu-2204
steps:
- name: Relocate docker volumes folder
run: |
Expand Down
Loading