track cache sizes [skip ci]#5840
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
| timer.elapsed().as_millis() | ||
| ); | ||
|
|
||
| metrics::TIPSET_CACHE_SIZE |
There was a problem hiding this comment.
It seems to be expensive to always update the metrics, I'd register a prometheus_client::collector::Collector instead
There was a problem hiding this comment.
Yeah, I know - no need to review this branch while in draft. It's just a dump of the code I had for analysing the memory usage.
|
closing in favour of #5920 |
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes
Other information and links
Change checklist