Skip to content

chore(ci): avoid rate-limiting with binstall#5831

Merged
LesnyRumcajs merged 1 commit intomainfrom
more-binstall
Jul 15, 2025
Merged

chore(ci): avoid rate-limiting with binstall#5831
LesnyRumcajs merged 1 commit intomainfrom
more-binstall

Conversation

@LesnyRumcajs
Copy link
Copy Markdown
Member

@LesnyRumcajs LesnyRumcajs commented Jul 15, 2025

Summary of changes

Changes introduced in this pull request:

  • cargo binstall might end up with 403s in case the token is missing. Best to add it, just in case the auto discovery fails (it happens in another repo we have)

From here

    /// If `--github-token` or environment variable `GITHUB_TOKEN`/`GH_TOKEN`
    /// is not specified, then cargo-binstall will try to extract github token from
    /// `$HOME/.git-credentials` or `$HOME/.config/gh/hosts.yml` by default.
    ///
    /// This option can be used to disable that behavior.
    #[clap(
        help_heading = "Overrides",
        long,
        env = "BINSTALL_NO_DISCOVER_GITHUB_TOKEN"
    )]
    pub(crate) no_discover_github_token: bool,

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Summary by CodeRabbit

  • Chores
    • Updated workflow configuration to set an additional environment variable for improved automation.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jul 15, 2025

Walkthrough

The GitHub Actions workflow for Rust linting was updated to set the GITHUB_TOKEN environment variable, sourced from repository secrets, during the "Install Lint tools" step. This change adds the token alongside the existing RUSTFLAGS environment variable, with no other adjustments to workflow logic or control flow.

Changes

File(s) Change Summary
.github/workflows/rust-lint.yml Added GITHUB_TOKEN env var to "Install Lint tools" step.

Poem

In the warren where code is spun,
A token joins the linting run.
Rusty tools now have a key,
To unlock secrets, quietly.
Hopping forward, checks are tight—
Linting rabbits do it right! 🐇✨


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@LesnyRumcajs LesnyRumcajs changed the title chore: rely more on binstall chore(ci): avoid rate-limiting with binstall Jul 15, 2025
@LesnyRumcajs LesnyRumcajs marked this pull request as ready for review July 15, 2025 09:04
@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner July 15, 2025 09:04
@LesnyRumcajs LesnyRumcajs requested review from hanabi1224 and sudo-shashank and removed request for a team July 15, 2025 09:04
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/workflows/rust-lint.yml (1)

65-68: GITHUB_TOKEN is already present in every run: step – consider dropping or hoisting to job-level env

GitHub automatically exports GITHUB_TOKEN for all steps, so this line is functionally redundant.
If your goal is to guarantee the token for all subsequent commands (e.g. make lint-all), move it to jobs.lint-all.env instead; otherwise you can safely delete it to keep the workflow uncluttered.

-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f50df3c and 11605a9.

📒 Files selected for processing (1)
  • .github/workflows/rust-lint.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: tests
  • GitHub Check: tests-release
  • GitHub Check: Build forest binaries on Linux AMD64
  • GitHub Check: Build Ubuntu
  • GitHub Check: cargo-publish-dry-run
  • GitHub Check: All lint checks

Comment thread .github/workflows/rust-lint.yml
@LesnyRumcajs LesnyRumcajs enabled auto-merge July 15, 2025 09:11
@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Jul 15, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 15, 2025
@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Jul 15, 2025
Merged via the queue into main with commit 3cf843a Jul 15, 2025
41 checks passed
@LesnyRumcajs LesnyRumcajs deleted the more-binstall branch July 15, 2025 14:25
@coderabbitai coderabbitai Bot mentioned this pull request Apr 8, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants