chore(ci): avoid rate-limiting with binstall#5831
Conversation
WalkthroughThe GitHub Actions workflow for Rust linting was updated to set the Changes
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
9fd10f3 to
11605a9
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/rust-lint.yml (1)
65-68:GITHUB_TOKENis already present in everyrun:step – consider dropping or hoisting to job-levelenvGitHub automatically exports
GITHUB_TOKENfor all steps, so this line is functionally redundant.
If your goal is to guarantee the token for all subsequent commands (e.g.make lint-all), move it tojobs.lint-all.envinstead; otherwise you can safely delete it to keep the workflow uncluttered.- GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/rust-lint.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: tests
- GitHub Check: tests-release
- GitHub Check: Build forest binaries on Linux AMD64
- GitHub Check: Build Ubuntu
- GitHub Check: cargo-publish-dry-run
- GitHub Check: All lint checks
Summary of changes
Changes introduced in this pull request:
cargo binstallmight end up with 403s in case the token is missing. Best to add it, just in case the auto discovery fails (it happens in another repo we have)From here
Reference issue to close (if applicable)
Closes
Other information and links
Change checklist
Summary by CodeRabbit