Skip to content

fix(cli): handle non-existing actors gracefully in F3 power proportion CLI#5173

Merged
LesnyRumcajs merged 3 commits intomainfrom
hm/f3-power-proportion-non-existing-actors
Jan 24, 2025
Merged

fix(cli): handle non-existing actors gracefully in F3 power proportion CLI#5173
LesnyRumcajs merged 3 commits intomainfrom
hm/f3-power-proportion-non-existing-actors

Conversation

@hanabi1224
Copy link
Copy Markdown
Contributor

@hanabi1224 hanabi1224 commented Jan 22, 2025

Summary of changes

Changes introduced in this pull request:

➜  lotus git:(master) ✗ lotus f3 pt gp 1179 1167 8888
{
  "Instance": 126141,
  "FromEC": false,
  "PowerTable": {
    "CID": "bafy2bzaced7pp3jghq3hdgaayl3uxcofhuedq6wwqm3pyer3oiywvqofobfto",
    "ScaledTotal": 65524
  },
  "ScaledSum": 12,
  "Proportion": 0.0001831390025028997,
  "NotFound": [
    8888
  ]
}
➜  forest git:(hm/f3-power-proportion-non-existing-actors) forest-cli f3 pt gp 1179 1167 8888
{
  "Instance": 126141,
  "FromEC": false,
  "PowerTable": {
    "CID": "bafy2bzaced7pp3jghq3hdgaayl3uxcofhuedq6wwqm3pyer3oiywvqofobfto",
    "ScaledTotal": 65524
  },
  "ScaledSum": 12,
  "Proportion": 0.0001831390025028997,
  "NotFound": [
    8888
  ]
}

Reference issue to close (if applicable)

Closes #5174

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@hanabi1224 hanabi1224 changed the title fix(cli): handle non-existing actors gracefully in F3 power proportio… fix(cli): handle non-existing actors gracefully in F3 power proportion CLI Jan 22, 2025
@hanabi1224 hanabi1224 marked this pull request as ready for review January 22, 2025 11:54
@hanabi1224 hanabi1224 requested a review from a team as a code owner January 22, 2025 11:54
@hanabi1224 hanabi1224 requested review from LesnyRumcajs and elmattic and removed request for a team January 22, 2025 11:54
@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Jan 24, 2025
Merged via the queue into main with commit 170613f Jan 24, 2025
@LesnyRumcajs LesnyRumcajs deleted the hm/f3-power-proportion-non-existing-actors branch January 24, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle non-existing actors gracefully in F3 power proportion CLI

3 participants