Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(f3): send the last gpbft message for each new participant #4912

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Oct 17, 2024

Summary of changes

This PR ports filecoin-project/lotus#12597 to avoid a deadlock situation where everyone is waiting for the next round to participate, but we'll never get there because not enough participants acted in the current round.

Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes #4911

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@hanabi1224 hanabi1224 marked this pull request as ready for review October 17, 2024 06:24
@hanabi1224 hanabi1224 requested a review from a team as a code owner October 17, 2024 06:24
@hanabi1224 hanabi1224 requested review from lemmih and LesnyRumcajs and removed request for a team October 17, 2024 06:24
@hanabi1224 hanabi1224 force-pushed the hm/f3-send-last-msg-for-new-participants branch from f6cf795 to 55406ba Compare October 17, 2024 06:38
Copy link
Member

@LesnyRumcajs LesnyRumcajs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we're doing the porting like Venus! :D

@hanabi1224 hanabi1224 added this pull request to the merge queue Oct 17, 2024
Merged via the queue into main with commit 7477856 Oct 17, 2024
34 checks passed
@hanabi1224 hanabi1224 deleted the hm/f3-send-last-msg-for-new-participants branch October 17, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

F3: send the last gpbft message for each new participant
3 participants