Update libp2p version to fix cargo issue#136
Merged
austinabell merged 6 commits intomasterfrom Jan 5, 2020
Merged
Conversation
austinabell
changed the title
austinabell
force-pushed
the
austin/libp2pv
branch
from
8a75361 to
8592aba
Compare
austinabell
requested review from
GregTheGreek,
ansermino,
dutterbutter and
ec2
austinabell
changed the title
ec2
approved these changes
Jan 5, 2020
ansermino
approved these changes
Jan 5, 2020
GregTheGreek
approved these changes
Jan 5, 2020
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue is protobuf version is not pinned in the fork we are using and causing issues. Temporary fix if working with a new Cargo.lock is to run:
Edit: No longer needed to do any of this since the gossipsub branch has been updated on sigp gossipsub libp2p branch, commit being used: https://github.com/sigp/rust-libp2p/tree/776d13ef046358964c7d64cda3295a3a3cb24743
commit from base libp2p that fixed the original issue: libp2p/rust-libp2p@455a5a9