Implementation of CAIP-2 for EOSIO blockchains#33
Conversation
…EOSIO implementation
ligi
left a comment
ligi
left a comment
There was a problem hiding this comment.
Please also add your CAIP to the list in the README
|
LGTM - but would love some more eye-ballz on it before the merge @pedrouid @webmaster128 @rekmarks |
webmaster128
left a comment
webmaster128
left a comment
There was a problem hiding this comment.
Oh, and this conflicts with https://github.com/ChainAgnostic/CAIPs/blob/master/CAIPs/caip-2.md#syntax. The reference part must not exceed 47 characters, which is why we use prefixes in https://github.com/ChainAgnostic/CAIPs/blob/master/CAIPs/caip-4.md
|
The alternative to prefixes is to use a different encoding for the 32 bytes. CAIP-2 is case-sensitive and you need 32/47 = 68% efficiency. So candidates are Base58 or Base62 (no idea how this encoding works but promising in theory). However, I think it is easier for human consumption to use a prefix of the default encoding than to re-encode it. |
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
…to use a prefix of the chain ID
|
I've updated the reference definition, to use a 32 character prefix of the Chain ID |
webmaster128
left a comment
webmaster128
left a comment
There was a problem hiding this comment.
Some wording 💅 but otherwise 👍
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
|
Great! Thanks! |
|
@ligi can we merge this? I don't have permissions to do so. |
3 participants
Initial draft of the CAIP-2 for EOSIO blockchains.