Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silence MSVC deprecation warning (wd4996) #762

Closed
wants to merge 1 commit into from
Closed

Silence MSVC deprecation warning (wd4996) #762

wants to merge 1 commit into from

Conversation

TheMostDiligent
Copy link
Contributor

Fix #761

@kring
Copy link
Member

kring commented Nov 20, 2023

Thanks for the PR @TheMostDiligent. Disabling WD4996 would disable all deprecation warnings, though, which is not good. Better to just disable these specific warnings by defining _SILENCE_STDEXT_ARR_ITERS_DEPRECATION_WARNING. You seem to have disallowed me to edit the code in this PR, so I'll close it and open a new one instead.

@kring kring closed this Nov 20, 2023
@TheMostDiligent
Copy link
Contributor Author

@kring Sounds good - thanks!

@TheMostDiligent TheMostDiligent deleted the silence_msvc_deprecation_warning branch November 30, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cesium-native fails to compile in Visual Studio 17.8.0
2 participants
@TheMostDiligent @kring