convert I3dm metadata to EXT_structural_metadata and EXT_instance_features #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The major refactor is to split the very rare case of EXT_mesh_gpu_instancing extension in the I3dm glTF into another function, and then reduce code duplication.
This class in PntsToGltfConverter.cpp is useful for dealing with instance metadata too.
kring
reviewed
Jan 14, 2025
| numInstances, | ||
| type); | ||
| gltf.accessors[static_cast<uint32_t>(accessorId)].byteOffset = | ||
| static_cast<int64_t>(bufferOffset); |
There was a problem hiding this comment.
Is this cast needed? It should be a widening conversion.
Also, for the one above, it's fine to use size_t(accessorId) rather than the more verbose static cast when you know the accessorId can't be negative. If you're not sure of that, add a runtime check rather than a static_cast. If it can only be negative as a result of a developer error, add a CESIUM_ASSERT(accessorId >= 0);.
There was a problem hiding this comment.
I think I was getting a warning about unsigned to signed conversion, but I will check that.
|
Thanks @timoore! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mostly follows the lead of PntsToGltfConverter.cpp in converting the I3dm batch table to structural metadata and EXT_instance_features feature IDs. It does not handle the obscure case of an I3dm gltf model that already contains EXT_mesh_gpu_instancing instances. Tested with cesium-unreal and a tileset tiled from CZML.
Happy new year!