Merge pull request #767 from CesiumGS/iterator-deprecation

Fix VS 2022 17.8 warnings/errors by defining _SILENCE_STDEXT_ARR_ITERS_DEPRECATION_WARNING
CesiumGS · Nov 21, 2023 · 4488777 · 4488777
2 parents 11140f0 + d1a602e
commit 4488777
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -24,6 +24,7 @@
 
 - Fixed a bug in `OrientedBoundingBox::contains` where it didn't account for the bounding box's center.
 - Fixed compiler error when calling `PropertyAttributeView::forEachProperty`.
+- Fixed WD4996 warnings-as-errors when compiling with Visual Studio 2002 v17.8.
 
 ### v0.29.0 - 2023-11-01
 

diff --git a/extern/CMakeLists.txt b/extern/CMakeLists.txt
@@ -68,6 +68,7 @@ add_subdirectory(asyncplusplus)
 
 set(SPDLOG_BUILD_TESTING OFF CACHE INTERNAL "Disable SPDLOG Testing")
 add_subdirectory(spdlog)
+target_compile_definitions(spdlog PUBLIC _SILENCE_STDEXT_ARR_ITERS_DEPRECATION_WARNING)
 
 if (NOT TARGET sqlite3)
   add_subdirectory(sqlite3)