Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement REPLACE interceptor #55

Merged
merged 5 commits into from
Apr 26, 2023
Merged

feat: implement REPLACE interceptor #55

merged 5 commits into from
Apr 26, 2023

Conversation

waynexia
Copy link
Member

Which issue does this PR close?

Closes #

Rationale for this change

Query result sometimes contains an unavoidable but also unimportant non-fix string, like the time it executes, or some local directories. This interceptor provides a way to replace them.

What changes are included in this PR?

  • interceptor REPLACE and relative test/example
  • bugfix: trim begin white space of concat-ed query string.

Are there any user-facing changes?

New interceptor REPLACE

How does this change test

example and unit test

Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Makefile Outdated Show resolved Hide resolved
Signed-off-by: Ruihang Xia <[email protected]>
Copy link
Member

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 added this pull request to the merge queue Apr 26, 2023
Merged via the queue into main with commit dde4b19 Apr 26, 2023
@waynexia waynexia deleted the interceptor-replace branch April 26, 2023 07:16
@waynexia
Copy link
Member Author

I plan to bump minor version after other interceptors are implemented

@jiacai2050
Copy link
Member

👍

Just don't forget update docs, there are little docs about interceptor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants