Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: public interceptor #54

Merged
merged 2 commits into from
Apr 18, 2023
Merged

chore: public interceptor #54

merged 2 commits into from
Apr 18, 2023

Conversation

jiacai2050
Copy link
Member

Which issue does this PR close?

Closes #

Rationale for this change

By public interceptor related trait, users can impl their own.

What changes are included in this PR?

  • Make interceptor public
  • Add builtin interceptor to config

Are there any user-facing changes?

No

How does this change test

CI

waynexia
waynexia approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 added this pull request to the merge queue Apr 18, 2023
Merged via the queue into main with commit bb19b2b Apr 18, 2023
@jiacai2050 jiacai2050 deleted the chore-interceptor branch April 18, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynexia waynexia waynexia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiacai2050 @waynexia