Skip to content

Commit

Permalink
Rollup merge of rust-lang#67308 - dtolnay:fast_rebind, r=alexcrichton
Browse files Browse the repository at this point in the history
Delete flaky test net::tcp::tests::fast_rebind

This test is unreliable for at least 3 users on two platforms: see rust-lang#57509 and rust-lang#51006. It was added 5 years ago in rust-lang#22015. Do we know whether this is testing something important that would indicate a bug in our implementation, or if it's fine to remove?

r? @sfackler @alexcrichton because this somewhat resembles rust-lang#59018

Closes rust-lang#57509. Closes rust-lang#51006.
  • Loading branch information
Centril authored Dec 16, 2019
2 parents a6f817f + 2514cd5 commit a1580e7
Showing 1 changed file with 0 additions and 15 deletions.
15 changes: 0 additions & 15 deletions src/libstd/net/tcp.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1312,21 +1312,6 @@ mod tests {
})
}

#[test]
fn fast_rebind() {
each_ip(&mut |addr| {
let acceptor = t!(TcpListener::bind(&addr));

let _t = thread::spawn(move || {
t!(TcpStream::connect(&addr));
});

t!(acceptor.accept());
drop(acceptor);
t!(TcpListener::bind(&addr));
});
}

#[test]
fn tcp_clone_smoke() {
each_ip(&mut |addr| {
Expand Down

0 comments on commit a1580e7

Please sign in to comment.