Hotfix/field values #1708
Hotfix/field values #1708
Conversation
lukavdplas
force-pushed
the
hotfix/field-values
branch
from
89da17b to
bd4b170
Compare
| <ng-container *ngIf="field && document"> | ||
| <ng-container *ngIf="document.highlight && document.highlight[field.name]; | ||
| else unhighlightedRow"> | ||
| <ng-container *ngFor="let highlight of document.highlight[field.name]; | ||
| last as isLast"> |
There was a problem hiding this comment.
Lots of ngIf and ngFor here. I wonder if an elvis operator could cut some lines?
There was a problem hiding this comment.
E.g. something like *ngFor=let highlight of document?.highlight[field?.name]
Probably wishful thinking :)
| else unhighlightedRow"> | ||
| <ng-container *ngFor="let highlight of document.highlight[field.name]; | ||
| last as isLast"> | ||
| <div ngPreserveWhitespaces style="word-break:break-word" |
There was a problem hiding this comment.
Minor DRY for the style. Could make it a class.
| @@ -0,0 +1,16 @@ | |||
| <ng-container *ngIf="field" [ngSwitch]="field.displayType"> | |||
| <div *ngSwitchCase="'text'" | |||
| [innerHtml]="field | elasticsearchHighlight:document | paragraph"> | |||
There was a problem hiding this comment.
This line is unclear to me. What is displayed as innerHtml in which cases?
There was a problem hiding this comment.
This is displayed if the field has display type text. (So it's tokenised as text, but not a text_content field - usually a title or something.)
I think the elasticsearchHighlight pipe adds the <mark> tags for highlights, and paragraph adds <p> tags for paragraphs.
|
I agree with your comments here; this is the kind of stuff I'm talking about when I say I still want to clean up these components some more. I think I'll make an update for that soon; I'll try to address your suggestions there as well. |
Fixes #1705, #1706, #1709
This also creates two separate components for displaying fields, instead of writing that logic in the document-view and document-preview components, because I was getting lost in the templates of those components.
I've been meaning to clean up these components a bit and straighten out some minor inconsistencies. For now, this at least fixes the missing values.