Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix date sorting in times corpus #1686

Merged
merged 1 commit into from
Nov 6, 2024
Merged

fix date sorting in times corpus #1686

merged 1 commit into from
Nov 6, 2024

Conversation

lukavdplas
Copy link
Contributor

close #1680

@lukavdplas lukavdplas added bug something isn't working right corpus changes to corpus definitions or new corpora labels Oct 31, 2024
@lukavdplas lukavdplas changed the title move sortable property on times fields fix date sorting in times corpus Oct 31, 2024
BeritJanssen
BeritJanssen approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@BeritJanssen BeritJanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks.

@lukavdplas lukavdplas merged commit d3e3326 into develop Nov 6, 2024
1 check passed
@lukavdplas lukavdplas deleted the bugfix/times-date-sort branch November 6, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BeritJanssen BeritJanssen BeritJanssen approved these changes

Assignees
No one assigned
Labels
bug something isn't working right corpus changes to corpus definitions or new corpora
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sort by date in Times broken?
2 participants
@lukavdplas @BeritJanssen