[ENG-2490] Upgrade ember to v3.26 #1203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Brian Geiger <[email protected]>
…ivate-in-element]
Notable Changes Polyfills have been removed entirely and with it the need to bundle the pluralization rules as they now come from the native Intl.PluralRules API Intl.MessageFormat parser and compiler updated which changes how text and tags are escaped Breaking Changes Node 8 support dropped Intl.RelativeTime polyfill has been replaced with the native API which behaves entirely different than the previous older spec implementation. Read more in the Migration Document Escaping text has changed and HTML tags now need to be escaped. Read how in the Migration Document Removes shortNumber formatting in favor of newly added native implementation using the "notation": "compact" parameter for Intl.NumberFormat i.e.,
Replace usage with <BsButton> Why: subclassing ember-bootstrap component classes no longer supported ember-bootstrap/ember-bootstrap#1104
aaxelb
reviewed
May 19, 2021
aaxelb
previously approved these changes
May 20, 2021
lib/osf-components/addon/components/contributor-list/unregistered-contributor/template.hbs
Show resolved
Hide resolved
lib/osf-components/addon/components/node-category-picker/template.hbs
Outdated
Show resolved
Hide resolved
lib/osf-components/addon/components/paginated-list/has-many/component.ts
Show resolved
Hide resolved
Fix noteworthy-and-popular-project tooltip
adlius
approved these changes
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Upgrade core ember-* to v3.26 (latest stable) + required dependency upgrades
Developer experience
App user experience
Summary of Changes
Changes fall into these categories:
nodeLicensevalidations are now nestedember-concurrency-async (support for async tasks)
ember-concurrency-ts (helpers for async tasks)
eslint plugins: eslint-plugin-import, eslint-plugin-node, eslint-plugin-prettier, eslint-plugin-ember-concurrency
ember-youtube (unused and outdated)
ember-cli-uglify (replaced by ember-cli-terser)
tslint (dropped in favor of typescript-eslint)
tslint-consistent-codestyle (dropped bc it's tslint plugin)
tslint-eslint-rules (dropped bc it's tslint plugin)
ember-oo-modifiers (replaced by ember-modifier)
ember-concurrency-test-waiter (usage replaced by @ember/test-helpers waitFor)
ember-concurrency-decorators (decorators are now part of ember-concurrency v2)
Side Effects
QA Notes